Commit eaba730
committed
security: bind localhost by default in the sandbox helper
tools/demo_sandbox.sh defaulted to 0.0.0.0:8080. The binary itself already
defaults to 127.0.0.1 and so do the just recipes, so this was the one host-run
path that exposed every interface without being asked.
It serves a language model with no authentication, no quota and no rate limit.
Exposing that should be a decision someone makes, not one they inherit from a
default, so MAINARCH_DEMO_BIND=0.0.0.0:8080 is now the explicit opt-in and the
docs say to put a proxy in front when taking it.
The container images still bind 0.0.0.0, which is correct inside a container
where the real decision is which ports get published.1 parent ceb1a63 commit eaba730
2 files changed
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
6 | 10 | | |
7 | 11 | | |
8 | 12 | | |
| |||
23 | 27 | | |
24 | 28 | | |
25 | 29 | | |
26 | | - | |
| 30 | + | |
27 | 31 | | |
28 | 32 | | |
29 | 33 | | |
| |||
0 commit comments