签名算法有问题

[mgicode]

System.out.println("from:"+SampleKeys.ADDRESS+","+signedResult.getFrom());
    
  //  assertEquals(SampleKeys.ADDRESS, signedResult.getFrom());      
  //  signedResult.verify(SampleKeys.ADDRESS);

单元测试中的这个不能注释掉啊，看样子所有单元测试都通过了，但是签名根本就用不了？

[mdranger]

This is commented out because this method is not used to sign Transactions.
In the README.rst file (https://github.com/MOACChain/chain3j/blob/master/README.rst), you can find the right method to sign the TX:
// sign & send out transaction with EIP155 signature
byte[] signedMessage = TransactionEncoder.signTxEIP155(rawTransaction, , credentials);
String hexValue = Hex.toHexString(signedMessage);
McSendTransaction mcSendTransaction = chain3j.SendRawTransaction(hexValue).send();

We will remove these tests in the next release.

[a114437]

sendRawTransaction question：
{"jsonrpc":"2.0","id":2,"error":{"code":-32000,"message":"rlp: input string too short for common.Address, decoding into (types.Transaction)(types.txdata).Recipient"}}

code:
BigInteger gasBigInteger = new BigInteger("22000");
if(StringUtils.isNotEmpty(gas)) {
gasBigInteger = Convert.toWei(gas, Convert.Unit.ETHER).toBigInteger();
}

BigInteger valueBigInteger = BigInteger.ZERO;
if(value!=null) {
valueBigInteger = Convert.toWei(value, Convert.Unit.ETHER).toBigInteger();
}

if(StringUtils.isNotEmpty(data)) {
data = "0x"+Numeric.toHexString(data.getBytes());
}else {
data = "0x0";
}

BigInteger nonce = getNonce(adress).add(new BigInteger("1"));
RawTransaction rawTransaction = RawTransaction.createTransaction(nonce, mcGasPrice(), gasBigInteger, to, valueBigInteger, data);

Credentials credentials = WalletUtils.loadCredentials("xxx", "C:\Users\Administrator\AppData\Roaming\MoacNode\testnet\keystore\UTC--2018-06-19T08-21-18.185054700Z--xxxxxxxxxxxxxxxxxxx");

byte[] signedMessage = TransactionEncoder.signMessage(rawTransaction, credentials);
String hexValue = Numeric.toHexString(signedMessage);
McSendTransaction ethSendTransaction =chain3j.mcSendRawTransaction(hexValue).sendAsync().get();
String transactionHash = ethSendTransaction.getTransactionHash();

[mdranger]

You should not use signMessage to send the transaction. Please use
Your code:
byte[] signedMessage = TransactionEncoder.signMessage(rawTransaction, credentials);
should be
byte[] signedMessage = TransactionEncoder.signTxEIP155(rawTransaction, , credentials);
Then you can send out the signed TX
String hexValue = Hex.toHexString(signedMessage);
McSendTransaction mcSendTransaction = chain3j.SendRawTransaction(hexValue).send();

[mdranger]

Please use branch version0.1.0 instead of Master. We will merge them soon.