Describe the bug
Hi TEASER++ team, I found a small issue that consistently generates a warning whenever I compile the TEASER++ library.
In test/teaser/registration-test.cc, the QUATRO rotation test uses the equality comparison operator (==) instead of the assignment operator (=) when setting params.inlier_selection_mode:
params.inlier_selection_mode ==
teaser::RobustRegistrationSolver::INLIER_SELECTION_MODE::PMC_HEU;
This produces the following compiler warning:
warning: equality comparison result unused [-Wunused-comparison]
Because the comparison result is discarded, PMC_HEU is not assigned to params.inlier_selection_mode, and the test may run using the default inlier-selection mode instead of the intended configuration.
The line should be changed to:
params.inlier_selection_mode =
teaser::RobustRegistrationSolver::INLIER_SELECTION_MODE::PMC_HEU;
Have you run the unit tests?
Installed Dependencies
- OS:
[Please add OS and version]
- Compiler:
[Please add compiler and version]
- TEASER++ version or commit:
[Please add version or commit]
- Other dependencies:
[Please add dependency versions]
To Reproduce
- Build TEASER++ with compiler warnings enabled.
- Compile
test/teaser/registration-test.cc.
- Observe the warning around line 191:
TEASER-plusplus/test/teaser/registration-test.cc:191:34:
warning: equality comparison result unused [-Wunused-comparison]
Describe the bug
Hi TEASER++ team, I found a small issue that consistently generates a warning whenever I compile the TEASER++ library.
In
test/teaser/registration-test.cc, the QUATRO rotation test uses the equality comparison operator (==) instead of the assignment operator (=) when settingparams.inlier_selection_mode:params.inlier_selection_mode == teaser::RobustRegistrationSolver::INLIER_SELECTION_MODE::PMC_HEU;This produces the following compiler warning:
Because the comparison result is discarded,
PMC_HEUis not assigned toparams.inlier_selection_mode, and the test may run using the default inlier-selection mode instead of the intended configuration.The line should be changed to:
params.inlier_selection_mode = teaser::RobustRegistrationSolver::INLIER_SELECTION_MODE::PMC_HEU;Have you run the unit tests?
Installed Dependencies
[Please add OS and version][Please add compiler and version][Please add version or commit][Please add dependency versions]To Reproduce
test/teaser/registration-test.cc.