debug submitting of kitems

Author: MBueschelberger

dsms/knowledge/kitem.py

@@ -297,6 +297,7 @@ def validate_linked_kitems_list(
         """Validate each single kitem to be linked"""
         linked_kitems = []
         logger.debug("Found KItem to link: %s", value)
+
         for item in value:
             if isinstance(item, dict):
                 item = KItemRelationshipModel(**item)

dsms/knowledge/properties/linked_kitems.py

@@ -33,7 +33,9 @@ class KItemRelationshipModel(BaseModel):
     """Data model for a relation between two linked KItems"""
 
     is_incoming: bool = Field(
-        False, description="Whether the relation is incoming"
+        False,
+        description="Whether the relation is incoming",
+        allow_mutation=False,
     )
     label: Optional[str] = Field(None, description="Label of the relation")
     kitem: Union[KItemCompactedModel, Any] = Field(

dsms/knowledge/utils.py

@@ -516,18 +516,29 @@ def _get_linked_diffs(
     """Get differences in linked kitem from previous KItem state"""
     differences = {}
     old_linked = [
-        old["kitem"].get("id") for old in old_kitem.get("linked_kitems")
+        {
+            "id": old["kitem"].get("id"),
+            "label": old["label"],
+            "iri": old["iri"],
+        }
+        for old in old_kitem.get("linked_kitems")
     ]
     new_linked = [
-        str(new_kitem.kitem.id) for new_kitem in new_kitem.linked_kitems
+        {
+            "id": str(new_kitem.kitem.id),
+            "label": new_kitem.label,
+            "iri": new_kitem.iri,
+        }
+        for new_kitem in new_kitem.linked_kitems
     ]
     differences["kitems_to_link"] = [
-        {"id": attr} for attr in new_linked if attr not in old_linked
+        attr for attr in new_linked if attr not in old_linked
     ]
     differences["kitems_to_unlink"] = [
-        {"id": attr} for attr in old_linked if attr not in new_linked
+        attr for attr in old_linked if attr not in new_linked
     ]
     logger.debug("Found differences in linked KItems: %s", differences)
+
     return differences
 
 

tests/test_utils.py

@@ -67,14 +67,22 @@ def test_kitem_diffs(get_mock_kitem_ids, custom_address):
         ],
         "linked_kitems": [
             {
-                "id": str(get_mock_kitem_ids[1]),
-                "ktype_id": dsms.ktypes.Organization.value,
-                "name": "foo456",
+                "iri": "https://example.org/has_part",
+                "label": "has part",
+                "kitem": {
+                    "id": str(get_mock_kitem_ids[1]),
+                    "ktype_id": dsms.ktypes.Organization.value,
+                    "name": "foo456",
+                },
             },
             {
-                "id": str(get_mock_kitem_ids[2]),
-                "ktype_id": dsms.ktypes.Organization.value,
-                "name": "foo789",
+                "iri": "https://example.org/has_part",
+                "label": "has part",
+                "kitem": {
+                    "id": str(get_mock_kitem_ids[2]),
+                    "ktype_id": dsms.ktypes.Organization.value,
+                    "name": "foo789",
+                },
             },
         ],
         "user_groups": [user_group],
@@ -109,7 +117,8 @@ def test_kitem_diffs(get_mock_kitem_ids, custom_address):
 
     expected = {
         "kitems_to_link": [
-            {"id": str(obj.kitem.id)} for obj in kitem_new.linked_kitems
+            {"id": str(obj.kitem.id), "label": obj.label, "iri": obj.iri}
+            for obj in kitem_new.linked_kitems
         ],
         "annotations_to_link": [
             {
@@ -129,7 +138,12 @@ def test_kitem_diffs(get_mock_kitem_ids, custom_address):
             }
         ],
         "kitems_to_unlink": [
-            {"id": str(linked.id)} for linked in [linked_kitem1, linked_kitem2]
+            {
+                "id": str(linked.id),
+                "label": "has part",
+                "iri": "https://example.org/has_part",
+            }
+            for linked in [linked_kitem1, linked_kitem2]
         ],
         "annotations_to_unlink": [
             {