Changelog stays empty

[soenkegissel]

If there are no informations about a new version and the versioncode is incremented the changelog is shown but with zero information.

.withMinVersionToShow(120) //currently 123
.withManagedShowOnStart(true)
.withFilter(new ChangelogFilter(ChangelogFilter.Mode.Exact, BuildConfig.FLAVOR, true)) // this will filter out all tags, that do not have the provided filter attribute

See my screenshot:

[soenkegissel]

For every new versionCode the library will show an empty box if no changes are put in the changelog.xml - as shown in the screenshot above.

[MFlisar]

Changelog entries are loaded when the dialog or activity is created - to support what you want this would need to be done before showing the dialog or activity. This was not intended - I never make releases with empty changelogs e.g..

Feel free to add this feature as a pull request though.

The only fast fix I could offer is to add some text like "This version only has internal changes and improvements" or similar as dialog/activity content if the displayed changelog is empty.

[jscti]

+1 for this need.

I don't want to spam my users for each one of my minor/fix releases, but only major and/or the ones with new features..
Depends for each apps/developer though

Looked quickly at the code lib and dirtyfixed by adding an IF but it's so ugly (causes an double changelog build) that I won't even do a PR for that ..

public ChangelogDialogFragment buildAndShowDialog(AppCompatActivity activity, boolean darkTheme) {
        boolean shouldShow = checkShouldShowAndUpdateMinVersion(activity);
        ChangelogDialogFragment dlg = null;
        if (shouldShow) {
            if (getRecyclerViewItems(activity).size() > 0) { // <======= HERE
                dlg = ChangelogDialogFragment.create(this, darkTheme);
                dlg.show(activity.getSupportFragmentManager(), ChangelogDialogFragment.class.getName());
            } else {
                Log.i(Constants.DEBUG_TAG, "Showing changelog dialog skipped because changelog to show is empty");
            }

        } else {
            Log.i(Constants.DEBUG_TAG, "Showing changelog dialog skipped");
        }
        ChangelogPreferenceUtil.updateAlreadyShownChangelogVersion(activity);
        return dlg;
    }

[MFlisar]

I just released a new version - its 100% kotlin + compose only though but it does what you want out of the box: https://github.com/MFlisar/ComposeChangelog