Review issues

Author: dnwiebe

multinode_integration_tests/tests/bookkeeping_test.rs

@@ -28,7 +28,7 @@ fn provided_and_consumed_services_are_recorded_in_databases() {
     thread::sleep(Duration::from_secs(10));
 
     let mut client = originating_node.make_client(8080, STANDARD_CLIENT_TIMEOUT_MILLIS);
-    client.set_timeout(Duration::from_secs(20));
+    client.set_timeout(Duration::from_secs(10));
     let request = "GET / HTTP/1.1\r\nHost: www.example.com\r\n\r\n".as_bytes();
 
     client.send_chunk(request);

node/src/proxy_client/stream_establisher.rs

@@ -50,11 +50,11 @@ impl StreamEstablisher {
         &mut self,
         payload: &ClientRequestPayload_0v1,
         ip_addrs: Vec<IpAddr>,
-        target_hostname: String,
+        target_hostname: &str,
     ) -> io::Result<Box<dyn SenderWrapper<SequencedPacket>>> {
         let connection_info = self.stream_connector.connect_one(
             ip_addrs,
-            &target_hostname,
+            target_hostname,
             payload.target_port,
             &self.logger,
         )?;

node/src/proxy_client/stream_handler_pool.rs

@@ -364,7 +364,7 @@ impl StreamHandlerPoolReal {
         let mut stream_establisher = StreamHandlerPoolReal::make_establisher(inner_arc);
         Box::new(
             future::lazy(move || {
-                stream_establisher.establish_stream(&payload, vec![ip_addr], target_hostname)
+                stream_establisher.establish_stream(&payload, vec![ip_addr], &target_hostname)
             })
             .map_err(|io_error| format!("Could not establish stream: {:?}", io_error)),
         )
@@ -452,8 +452,7 @@ impl StreamHandlerPoolReal {
             logger,
             "Found IP addresses for {}: {:?}", target_hostname, &filtered_ip_addrs
         );
-        let result =
-            establisher.establish_stream(payload, filtered_ip_addrs, target_hostname.clone());
+        let result = establisher.establish_stream(payload, filtered_ip_addrs, &target_hostname);
         match result {
             Ok(sender_wrapper) => {
                 debug!(

node/src/sub_lib/neighborhood.rs

@@ -75,7 +75,7 @@ pub enum NeighborhoodMode {
 }
 
 impl Display for NeighborhoodMode {
-    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
         match self {
             NeighborhoodMode::Standard(_, _, _) => write!(f, "Standard"),
             NeighborhoodMode::ZeroHop => write!(f, "ZeroHop"),