chore(phpstan): genericise ForbidHttpPrefixedEnvVarsRule example var names

Replace domain-specific example env var names (egress-proxy/HTTP-cache
vocabulary) in the rule's error message and its test fixtures with fully
generic placeholders (HTTP_API_KEY/APP_API_KEY, HTTP_CACHE_DIR/APP_CACHE_DIR,
APP_FEATURE_FLAGS). This is a public, general-purpose library consumed by
many unrelated projects — its examples must not carry any one consumer's
domain vocabulary. No behavioural change.

Author: LTSCommerce

src/PHPStan/Rules/ForbidHttpPrefixedEnvVarsRule.php

@@ -105,7 +105,7 @@ public function processNode(Node $node, Scope $scope): array
                 '%s:%d: env var \'%s\' is consumed by Symfony but named with an HTTP_ prefix — '
                 . 'Symfony treats HTTP_* as an HTTP request header and will NOT read it from '
                 . '$_SERVER, so a CLI process (worker/console/cron) resolves it EMPTY. Rename it '
-                . 'off the HTTP_ prefix (e.g. HTTP_EGRESS_PROXY -> APP_EGRESS_PROXY).',
+                . 'off the HTTP_ prefix (e.g. HTTP_API_KEY -> APP_API_KEY).',
                 $file,
                 $line,
                 $name,

tests/Small/PHPStan/Rules/ForbidHttpPrefixedEnvVarsRuleTest.php

@@ -54,10 +54,10 @@ public function offendingFixtureIsFlaggedWithEveryHttpPrefixedNameInDeterministi
         // PHPStan's own file/line metadata cannot point outside the file
         // actually being analysed (see the rule's docblock).
         $this->analyse([self::ASSETS . '/dummy.php'], [
-            [$this->expectedMessage(self::ASSETS . '/offending/.env', 4, 'HTTP_EGRESS_PROXY'), 3],
-            [$this->expectedMessage(self::ASSETS . '/offending/config/services.yaml', 2, 'HTTP_EGRESS_PROXY'), 3],
-            [$this->expectedMessage(self::ASSETS . '/offending/config/services.yaml', 8, 'HTTP_EGRESS_PROXY'), 3],
-            [$this->expectedMessage(self::ASSETS . '/offending/config/services.yaml', 9, 'HTTP_CACHE_ROOT'), 3],
+            [$this->expectedMessage(self::ASSETS . '/offending/.env', 4, 'HTTP_API_KEY'), 3],
+            [$this->expectedMessage(self::ASSETS . '/offending/config/services.yaml', 2, 'HTTP_API_KEY'), 3],
+            [$this->expectedMessage(self::ASSETS . '/offending/config/services.yaml', 8, 'HTTP_API_KEY'), 3],
+            [$this->expectedMessage(self::ASSETS . '/offending/config/services.yaml', 9, 'HTTP_CACHE_DIR'), 3],
         ]);
     }
 
@@ -91,7 +91,7 @@ private function expectedMessage(string $file, int $line, string $name): string
             '%s:%d: env var \'%s\' is consumed by Symfony but named with an HTTP_ prefix — '
             . 'Symfony treats HTTP_* as an HTTP request header and will NOT read it from '
             . '$_SERVER, so a CLI process (worker/console/cron) resolves it EMPTY. Rename it '
-            . 'off the HTTP_ prefix (e.g. HTTP_EGRESS_PROXY -> APP_EGRESS_PROXY).',
+            . 'off the HTTP_ prefix (e.g. HTTP_API_KEY -> APP_API_KEY).',
             $file,
             $line,
             $name,

tests/assets/httpPrefixedEnvVars/clean/.env

@@ -1,3 +1,3 @@
 APP_ENV=dev
-SITE_FETCH_EGRESS_CHANNELS=proxyA,proxyB
-APP_EGRESS_PROXY=http://nordegress:8888
+APP_FEATURE_FLAGS=flagA,flagB
+APP_API_KEY=abc123secret

tests/assets/httpPrefixedEnvVars/clean/config/services.yaml

@@ -1,10 +1,10 @@
 parameters:
-    env(APP_CACHE_ROOT): ''
-    app.some_other_param: '%env(SITE_FETCH_EGRESS_CHANNELS)%'
+    env(APP_CACHE_DIR): ''
+    app.some_other_param: '%env(APP_FEATURE_FLAGS)%'
 
 services:
-    App\Service\Egress\ProxyClient:
+    App\Service\SomeClient:
         arguments:
-            $proxy: '%env(APP_EGRESS_PROXY)%'
-            $cacheRoot: '%env(string:APP_CACHE_ROOT)%'
-            $channels: '%env(csv:SITE_FETCH_EGRESS_CHANNELS)%'
+            $apiKey: '%env(APP_API_KEY)%'
+            $cacheDir: '%env(string:APP_CACHE_DIR)%'
+            $featureFlags: '%env(csv:APP_FEATURE_FLAGS)%'

tests/assets/httpPrefixedEnvVars/offending/.env

@@ -1,4 +1,4 @@
 # Deliberately offending fixture — do NOT copy this pattern.
 APP_ENV=dev
-SITE_FETCH_EGRESS_CHANNELS=proxyA,proxyB
-HTTP_EGRESS_PROXY=http://nordegress:8888
+APP_FEATURE_FLAGS=flagA,flagB
+HTTP_API_KEY=abc123secret

tests/assets/httpPrefixedEnvVars/offending/config/services.yaml

@@ -1,10 +1,10 @@
 parameters:
-    env(HTTP_EGRESS_PROXY): ''
-    app.some_other_param: '%env(SITE_FETCH_EGRESS_CHANNELS)%'
+    env(HTTP_API_KEY): ''
+    app.some_other_param: '%env(APP_FEATURE_FLAGS)%'
 
 services:
-    App\Service\Egress\ProxyClient:
+    App\Service\SomeClient:
         arguments:
-            $proxy: '%env(HTTP_EGRESS_PROXY)%'
-            $cacheRoot: '%env(string:HTTP_CACHE_ROOT)%'
-            $channels: '%env(csv:SITE_FETCH_EGRESS_CHANNELS)%'
+            $apiKey: '%env(HTTP_API_KEY)%'
+            $cacheDir: '%env(string:HTTP_CACHE_DIR)%'
+            $featureFlags: '%env(csv:APP_FEATURE_FLAGS)%'