Merge branch 'main' into show-own-reuploads-as-real-publisher

Author: jvyden

Refresh.Database/GameDatabaseContext.Levels.cs

@@ -646,7 +646,7 @@ public void ApplyLevelMetadataFromAttributes(GameLevel level, bool save = false)
             Dictionary<string, string> levelAttributes = LevelPrefixes.ExtractAttributes(level.Description);
 
             // Get original publisher from ?op.{username} or ?op:{username} otherwise Unknown
-            level.OriginalPublisher = levelAttributes.GetValueOrDefault("op") ?? SystemUsers.UnknownUserName; 
+            level.OriginalPublisher = levelAttributes.GetValueOrDefault("op"); 
         }
 
         if (save)

Refresh.Database/Migrations/20250725200929_FixIncorrectOpAttributeBehavior.cs

@@ -0,0 +1,25 @@
+using Microsoft.EntityFrameworkCore.Infrastructure;
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace Refresh.Database.Migrations
+{
+    [DbContext(typeof(GameDatabaseContext))]
+    [Migration("20250725200929_FixIncorrectOpAttributeBehavior")]
+    /// <inheritdoc />
+    public partial class FixIncorrectOpAttributeBehavior : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.Sql("UPDATE \"GameLevels\" SET \"OriginalPublisher\" = null WHERE \"OriginalPublisher\" = '!Unknown'");
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            // no-op, this is part of a bugfix
+        }
+    }
+}

RefreshTests.GameServer/Tests/Levels/ReuploadDetectionTests.cs

@@ -35,7 +35,7 @@ public void ReuploadDetectedInTitle(string suffix)
         using (Assert.EnterMultipleScope())
         {
             Assert.That(level.IsReUpload, Is.True);
-            Assert.That(level.OriginalPublisher, Is.EqualTo(SystemUsers.UnknownUserName));
+            Assert.That(level.OriginalPublisher, Is.Null);
         }
     }