Increase test coverage from 60% to 80%

[Liohtml]

Description

Current test coverage is ~60%. We need more tests for:

• src/medcheck/pipeline/report.py - PDF and HTML generation
• src/medcheck/main.py - CLI command execution
• src/medcheck/web/app.py - API endpoints
• src/medcheck/pipeline/vision_analysis.py - prompt building edge cases
• src/medcheck/providers/local.py - ZIP handling edge cases

Each checkbox can be a separate PR. Pick one and submit!

How to check coverage

```bash
uv run pytest --cov=medcheck --cov-report=html
open htmlcov/index.html
```

[Liohtml]

Assessment

Valid goal. 60% → 80% is achievable with focused effort. The current 55% enforcement floor means some PRs are almost certainly being shipped at exactly 55% (the minimum), which isn't meaningful coverage.

My take on priority order for the five areas mentioned:

1. web/app.py — easiest, highest ROI: Two real endpoints exist (/health, /api/analyze stub). TestClient + a few assertions gets you to 100% on this file in 30 minutes. Start here.

2. main.py CLI — straightforward: typer.testing.CliRunner makes this easy. Cover analyze (success + provider-not-found error), serve (just checks it starts), download-models stub. ~1 hour.

3. vision_analysis.py edge cases — important: The JSON parsing in parse_llm_response (in src/medcheck/llm/base.py) is critical — it handles LLM responses that may or may not be valid JSON, may be wrapped in markdown fences, etc. Edge cases: empty response, malformed JSON, valid JSON missing required fields. These cover real production failure modes.

4. report.py PDF/HTML — medium effort: Mock reportlab where needed. Test that the PDF/HTML bytes are non-empty and contain expected patient pseudonym strings. Don't test PDF internals, just that the output is produced.

5. local.py ZIP handling — add a real ZIP fixture: Create a ZIP of synthetic DICOM bytes in conftest.py using Python's zipfile module. Test that ZIPs with 0 DICOM files return empty, 1 file returns 1, and corrupt ZIPs are handled.

Also raise the threshold: Once you're at 80%, bump --cov-fail-under=80 in pyproject.toml so it doesn't drift back.

What I'd actually do: Write these as 4 separate PRs (one per module), each raising the baseline by ~5-6%. Easier to review, easier to track progress, and each PR is shippable independently.

Effort: ~6-8 hours total across all five areas.

[Liohtml]

Done — total coverage is now 86 % and the CI enforcement floor was raised from 55 % to 80 % in #125 (--cov-fail-under=80 plus fail_under = 80 in pyproject.toml), so it can't regress below the target. An end-to-end integration suite was also added in the same PR (#93).

---

Generated by Claude Code