Skip to content

App may hang if you press cancel while PCM is in recovery mode #114

Description

@LegacyNsfw

Seen with ELM-based devices, may or may not affect others.

The first loop in ElmDeviceImplementation.ReadElmLine doesn't check for \r characters. If the PCM is in recovery mode it will loop until the buffer is full, receiving the PCM's recovery-mode pings. This can take a very long time, and the app just appears hung.

Not sure what the side effects would be, though. Subsequent calls to ReadElmLine may or may not just pick up the read of the buffered messages. This would need a lot of testing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions