fix: preserve telemetry failure isolation

Author: Ldsystem

scripts/invocation_observation.py

@@ -39,6 +39,11 @@ def extract_command(
         if token == "--project-root":
             if index + 1 >= len(argv):
                 return NO_COMMAND
+            value = argv[index + 1]
+            if value in {"-h", "--help"}:
+                return NO_COMMAND
+            if value.startswith("-"):
+                return UNKNOWN_COMMAND
             index += 2
             continue
         if token.startswith("--project-root="):
@@ -108,8 +113,8 @@ def _connect(database: Path) -> sqlite3.Connection:
 def _begin(surface: str, command: str) -> tuple[Path, int] | None:
     if os.environ.get(DISABLE_ENV) == "0":
         return None
-    database = _database_path()
     try:
+        database = _database_path()
         with closing(_connect(database)) as connection:
             with connection:
                 cursor = connection.execute(
@@ -121,7 +126,7 @@ def _begin(surface: str, command: str) -> tuple[Path, int] | None:
                 )
                 row_id = int(cursor.lastrowid)
         return database, row_id
-    except (OSError, sqlite3.Error):
+    except (OSError, RuntimeError, sqlite3.Error):
         return None
 
 

tests/test_invocation_observation.py

@@ -57,6 +57,12 @@ def test_surface_aware_command_extraction_never_persists_option_values() -> None
         "orch", ["--project-root=/private/path", "doctor"], recognized
     ) == "doctor"
     assert observation.extract_command("orch", ["--help", "doctor"], recognized) == "__no_command__"
+    assert observation.extract_command(
+        "orch", ["--project-root", "--help", "doctor"], recognized
+    ) == "__no_command__"
+    assert observation.extract_command(
+        "orch", ["--project-root", "--unknown", "doctor"], recognized
+    ) == "__unknown__"
     assert observation.extract_command("orch", ["--project", "/secret", "doctor"], recognized) == "__unknown__"
 
 
@@ -148,6 +154,17 @@ def test_database_failure_is_silent_and_does_not_change_dispatch(
     assert capsys.readouterr() == ("", "")
 
 
+def test_config_root_resolution_failure_is_silent_and_does_not_change_dispatch(
+    monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
+) -> None:
+    observation = load_observation()
+    monkeypatch.setenv("WORK_BUNDLE_INVOCATION_LOG", "1")
+    monkeypatch.setenv("WB_CONFIG_ROOT", "~workbundle-user-that-does-not-exist/usage")
+
+    assert observation.invoke_observed("wb", ["doctor"], {"doctor"}, lambda: 7) == 7
+    assert capsys.readouterr() == ("", "")
+
+
 @pytest.mark.parametrize(("filename", "surface"), [("wb.py", "wb"), ("orch.py", "orch")])
 def test_public_wrappers_observe_once(
     enabled: Path, monkeypatch: pytest.MonkeyPatch, filename: str, surface: str