Summary
Several RSS defects in rsslib.php:
:155-159 format_text($desc, 'HTML', ['trusted' => true]) - the string 'HTML' is not FORMAT_HTML (it resolves to FORMAT_MOODLE), and trusted => true disables cleaning for student-authored summaries regardless of the episode's own trust flag. (This line was touched by the most recent commit but the format arg was not fixed.):161-169, :517 $item->topcategory is never assigned, so <itunes:category> is never emitted; the per-item category lookup is pure overhead.:512 $item->course === SITEID compares a string to int(1) and is always false, so front-page feeds drop items.:683 !empty($category->subtitle) should read $pcast->subtitle.
Location
rsslib.php:155-159, 161-169, 512, 517, 683
Suggested fix
Select and pass e.summaryformat; assign/emit the category; cast course to int; fix the subtitle source.
Found during the mod_pcast review/test pass (ClickUp 86cb46r9t). Line numbers are against master @ 73bb255.
Summary
Several RSS defects in
rsslib.php::155-159format_text($desc, 'HTML', ['trusted' => true])- the string'HTML'is notFORMAT_HTML(it resolves toFORMAT_MOODLE), andtrusted => truedisables cleaning for student-authored summaries regardless of the episode's own trust flag. (This line was touched by the most recent commit but the format arg was not fixed.):161-169, :517$item->topcategoryis never assigned, so<itunes:category>is never emitted; the per-item category lookup is pure overhead.:512$item->course === SITEIDcompares a string toint(1)and is always false, so front-page feeds drop items.:683!empty($category->subtitle)should read$pcast->subtitle.Location
rsslib.php:155-159, 161-169, 512, 517, 683Suggested fix
Select and pass
e.summaryformat; assign/emit the category; castcourseto int; fix the subtitle source.Found during the mod_pcast review/test pass (ClickUp 86cb46r9t). Line numbers are against
master@ 73bb255.