Skip to content

Backup omits enablerssitunes, episodesperpage and summary files #14

Description

@nihaalshaikh

Summary

Three backup gaps:

  1. backup/moodle2/backup_pcast_stepslib.php:39 lists 'enableitunes', but the column is enablerssitunes (db/install.xml:29). The element is empty and dropped on restore.
  2. episodesperpage (install.xml:19) is missing from the element list.
  3. The summary file area is never annotated/related (backup_pcast_stepslib.php, restore_pcast_stepslib.php); only intro/logo/episode are.

Impact

On restore, iTunes RSS resets to 0, per-page setting reverts to the default 10, and every image embedded in an episode summary is lost (broken @@PLUGINFILE@@).

Location

backup/moodle2/backup_pcast_stepslib.php:39, 136; restore_pcast_stepslib.php:167

Suggested fix

Rename enableitunes -> enablerssitunes, add episodesperpage, and annotate/relate the summary file area.


Found during the mod_pcast review/test pass (ClickUp 86cb46r9t). Line numbers are against master @ 73bb255.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghighHigh: bug or significant quality issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions