Skip to content

Securitry: Pin bash in dockerfile #168

Description

@helge000

Describe the Bug

The current Dockerfile fails build check because of missing JSON args, failing my CI. To fix this, we should explicitly set bash, as we need shell for command chaining.

Check complete, 1 warning has been found!

WARNING: JSONArgsRecommended - https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
JSON arguments recommended for CMD to prevent unintended behavior related to OS signals
Dockerfile:51
--------------------
  50 |     
  51 | >>> CMD : \
  52 | >>>      && node /directus/cli.js bootstrap \
  53 | >>>      && node /directus/cli.js start \
  54 | >>>      ;
  55 |     
--------------------

To Reproduce

Run docker build --check .

Directus Version

v9.11.0.1

Hosting Strategy

Self-Hosted (Docker Image)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions