A15: Expand IDEDriveDescriptorTest assertions

[LSantha]

Title: Expand assertions in IDEDriveDescriptorTest
Source: fs/src/driver/bus/ide/IDEDriveDescriptor.java
Current: fs/src/test/org/jnode/test/driver/bus/ide/IDEDriveDescriptorTest.java — JUnit4, 20 methods, 10 assertions (low-assertion-density)
Approach: Add assertions for all 20 test methods covering CHS/LBA addressing, capacity, model/serial parsing, SMART data
Register: Already in FSTestSuite

[LSantha]

/oc Please proceed with this task.

[opencode-agent]

🤖 PR Opened: #592

Summary: Expanded IDEDriveDescriptorTest from 10 low-assertion-density tests to 18 comprehensive test methods (46 assertions total).

Changes:

• Added 8 new tests: testIsDisk, testIsCDROM, testIsTape, testIsAtapi, testToString, testCdromSerialNumber, testCdromModel, testCdromFirmware
• Expanded all existing tests with bit-level verification (LBA, DMA, ATA, removable bits), null checks, boundary validations, and a 28-bit addressing path test via cloned descriptor

Testing: cd fs && ant -f build-tests.xml all-junit → 18/18 PASS

opencode session  |  github run

[LSantha]

/oc Please proceed with this task.

[LSantha]

/oc Please proceed with this task.

[opencode-agent]

Analysis Summary

Issue #525 (A15): "Expand IDEDriveDescriptorTest assertions"

• Current test file: 10 test methods with low assertion density
• Requirement: Add assertions covering CHS/LBA addressing, capacity, model/serial parsing, SMART data

PR #592 Status:

• ✅ Adds 8 new test methods (isDisk, isCDROM, isTape, isAtapi, toString, cdromSerialNumber, cdromModel, cdromFirmware)
• ✅ Expands existing tests with bit-level verification (LBA, DMA, ATA, removable bits)
• ✅ Adds null checks and boundary validations
• ✅ Tests 28-bit addressing path via cloned descriptor
• ❌ References wrong issue: "Closes Add missing @Override annotations to Comparable implementations #15" instead of "Closes A15: Expand IDEDriveDescriptorTest assertions #525"

Coverage Analysis:
The PR covers all 15 public methods in IDEDriveDescriptor.java:

• Constructor, getSerialNumber, getFirmware, getModel
• isDisk, isCDROM, isTape, toString, isAtapi, isAta, isRemovable
• supportsLBA, supportsDMA, supports48bitAddressing, getSectorsAddressable

Note: The issue mentions "CHS/LBA addressing" and "SMART data", but the IDEDriveDescriptor class doesn't contain CHS or SMART methods - only LBA-related methods. The PR adequately covers all available functionality.

Plan

1. Fix PR Expand IDEDriveDescriptorTest assertions (Closes #525) #592 issue reference - Change "Closes Add missing @Override annotations to Comparable implementations #15" to "Closes A15: Expand IDEDriveDescriptorTest assertions #525"
2. Run tests - Verify cd fs && ant -f build-tests.xml all-junit passes
3. Update issue A15: Expand IDEDriveDescriptorTest assertions #525 - Mark as complete with PR reference

The PR implementation is comprehensive and addresses the issue requirements. The only fix needed is the incorrect issue reference.

opencode session  |  github run

[opencode-agent]

🤖 Done

PR #592 updated and verified:

• 18 test methods, 46 assertions — all pass
• Removed 11 explanatory comments per AGENTS.md convention
• Java 1.6 compliant, US-ASCII, LGPL header present
• Covers all 15 public methods: string parsing (serial/model/firmware), addressing (LBA/28-bit/48-bit), device type (ATA/ATAPI/disk/CDROM/tape), capabilities (DMA/removable), toString, constructor validation

opencode session  |  github run

[LSantha]

/oc Please proceed with this task.

[LSantha]

🤖 Status Update

PR #592 updated with correct issue reference.

Changes:

• Fixed PR title: "Expand IDEDriveDescriptorTest assertions (Closes A15: Expand IDEDriveDescriptorTest assertions #525)"
• Fixed PR body: references A15: Expand IDEDriveDescriptorTest assertions #525 instead of Add missing @Override annotations to Comparable implementations #15

Test verification:

• IDEDriveDescriptorTest: 18/18 PASS, 0 failures, 0 errors
• Covers all 15 public methods in IDEDriveDescriptor.java
• Self-check: Java 1.6 compliant, US-ASCII, no new comments, LGPL header present

PR is OPEN, MERGEABLE, and CI build-and-test passed.

[opencode-agent]

Summary

PR #592 has been updated and verified:

• Issue reference fixed: Changed from "Closes Add missing @Override annotations to Comparable implementations #15" to "Closes A15: Expand IDEDriveDescriptorTest assertions #525"
• Tests: 18/18 pass (8 new tests + 10 expanded tests)
• Coverage: All 15 public methods in IDEDriveDescriptor.java
• CI: Build-and-test check passed
• Self-check: Java 1.6, US-ASCII, no new comments, LGPL header present

opencode session  |  github run