Commit d5b2ce7
Fix silently discarded save failures in Language/DictionaryItem/Webhook serializers (#1040)
SaveItemAsync discarded the Attempt<T, Status> returned by ILanguageService,
IDictionaryItemService, and IWebhookService, so a failed create/update (e.g.
an ISO code rejected by Umbraco's IsoCodeValidator) was silently dropped
while the import still reported success. Now throws when the attempt fails,
so the failure surfaces in the import results and log instead of vanishing.
Fixes #1038
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>1 parent b2ed399 commit d5b2ce7
3 files changed
Lines changed: 29 additions & 3 deletions
File tree
- uSync.Core/Serialization/Serializers
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
231 | | - | |
| 231 | + | |
| 232 | + | |
232 | 233 | | |
233 | 234 | | |
234 | 235 | | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
235 | 243 | | |
236 | 244 | | |
237 | 245 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
| 155 | + | |
| 156 | + | |
156 | 157 | | |
157 | 158 | | |
158 | 159 | | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
159 | 167 | | |
160 | 168 | | |
161 | 169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
54 | 64 | | |
55 | 65 | | |
56 | 66 | | |
| |||
0 commit comments