Reloading roles watcher

[TiBarification]

I have a concern about logic of

SCPDiscord/SCPDiscordPlugin/RoleSync.cs

Line 57 in 5ead793

fileWatcher = new Utilities.FileWatcher(Config.GetRolesyncDir(), "rolesync.json", Reload);

It looks each time file get updated Reload function triggered causing execution of function twice. For example here we saving data and on line 57 it reloads file but why if we added player into memory and removed

I can be wrong but feels like more useful to move from file sync to some sort of db with parallel usage and some lockers.

[KarlOfDuty]

You are right, there is a possible race condition here but it is extremely unlikely to occur as these actions are individually triggered by human action. It would require two people to use a role command on the same server at the exact same time.

What kind of database solution are you thinking? I could be open for that if it is something simple.

[TiBarification]

You are right, there is a possible race condition here but it is extremely unlikely to occur as these actions are individually triggered by human action. It would require two people to use a role command on the same server at the exact same time.

What kind of database solution are you thinking? I could be open for that if it is something simple.

I am using mongodb with SCPUtils, but appreciate if there will be some kind of interface or abstract class, so it is possible to specify own driver for that, similar what have [XPSystem] (https://github.com/RowpannSCP/XP/tree/master/XPSystem/BuiltInProviders) or something similar.

possible race condition here but it is extremely unlikely to occur as these actions are individually triggered by human action.

Today I got this, and it is weird because on other servers it is ok. After removing watcher logic works much better. The only reason I see to watch on file if you try to edit it directly, but I prefer to do though discord commands, much safer.

[2025-03-03 19:45:45.375 +02:00] �[37m[�[1m�[35mDebug�[22m�[37m] �[37m[�[1m�[32mSCPDiscord�[22m�[37m]�[0m Successfully loaded '/data/.config/SCP Secret Laboratory/PluginAPI/plugins/7780/SCPDiscord/rolesync.json'.
[2025-03-03 19:45:45.414 +02:00] �[37m[�[1m�[35mDebug�[22m�[37m] �[37m[�[1m�[32mSCPDiscord�[22m�[37m]�[0m Successfully loaded '/data/.config/SCP Secret Laboratory/PluginAPI/plugins/7780/SCPDiscord/rolesync.json'.
[2025-03-03 19:45:45.424 +02:00] �[37m[�[1m�[35mDebug�[22m�[37m] �[37m[�[1m�[32mSCPDiscord�[22m�[37m]�[0m Successfully loaded '/data/.config/SCP Secret Laboratory/PluginAPI/plugins/7780/SCPDiscord/rolesync.json'.
[2025-03-03 19:45:45.434 +02:00] �[37m[�[1m�[35mDebug�[22m�[37m] �[37m[�[1m�[32mSCPDiscord�[22m�[37m]�[0m Successfully loaded '/data/.config/SCP Secret Laboratory/PluginAPI/plugins/7780/SCPDiscord/rolesync.json'.