Possible compatibility with ToolStats by hyperdefined

[DereC4]

Toolstats is a great plugin that adds, well, stats to your tools, but it also uses item lore components. Running epicrename /lore command removes toolstats lore. It seems toolstats stores the blocks mined, but nothing else for said tool which is a lil sad

Image 1 shows the pickaxe after changing lore, image 2 is after mining a block, which then returns the stat. Image 3 is the original pickaxe stats from ToolStats

I was wondering if there was any chance y'all could be compatible together! Citing https://github.com/hyperdefined/ToolStats/issues/120

[JustBru00]

Let me take a look at how this plugin functions.

You can add some basic compatibility right now by blacklisting things from being changed on these items.
In your config.yml, you can add the following to blacklists.existingloreline.

blacklists:
  material:
    - 'VAILD_MATERIAL_HERE'
  #Only player provided text is checked against the text blacklist. 
  #Use blacklists.existingname or blacklists.existingloreline to prevent players from 
  #editing already created items with certain text as part of their name or lore.
  text:
    - 'some_bad_phrase_here'
  
  #These values are checked without color and are case insensitive.  
  existingname:
    - 'a name that is not case sensitive'
  
  #These values are checked without color and are case insensitive.    
  existingloreline:
    - 'blocks mined:'
    - 'looted on:'
    - 'looted by:'

Any items with those lore lines will be blocked from being changed by the plugin, unless the player has the epicrename.bypass.existinglore permission.
That should give you a pretty quick fix to this problem.

I will dig into it and see if there is an easy way to detect one of these items automatically.

[JustBru00]

It looks like ToolStats stores item data on in the PersistentDataContainer in the ItemMeta itself. I should be able to detect if any keys from the toolstats: namespace are on the item. If they are we could block the command.

Would you just want lore blocked or everything?

[DereC4]

Let me take a look at how this plugin functions.

You can add some basic compatibility right now by blacklisting things from being changed on these items. In your config.yml, you can add the following to blacklists.existingloreline.

blacklists:
material:
- 'VAILD_MATERIAL_HERE'
#Only player provided text is checked against the text blacklist.
#Use blacklists.existingname or blacklists.existingloreline to prevent players from
#editing already created items with certain text as part of their name or lore.
text:
- 'some_bad_phrase_here'

#These values are checked without color and are case insensitive.
existingname:
- 'a name that is not case sensitive'

#These values are checked without color and are case insensitive.
existingloreline:
- 'blocks mined:'
- 'looted on:'
- 'looted by:'
Any items with those lore lines will be blocked from being changed by the plugin, unless the player has the epicrename.bypass.existinglore permission. That should give you a pretty quick fix to this problem.

I will dig into it and see if there is an easy way to detect one of these items automatically.

Oo that's cool! Does it check for exact values of contains vals?

Also ty for such a fast response

[DereC4]

It looks like ToolStats stores item data on in the PersistentDataContainer in the ItemMeta itself. I should be able to detect if any keys from the toolstats: namespace are on the item. If they are we could block the command.

Would you just want lore blocked or everything?

Hm honestly it would be cool if lore could just be appended at the end of the stats without overriting them, but i am not sure how that would work. Then we wouldn't need to block the command on detection of the PDC info for toolstats, instead just adding it on