tmate

Author: JamesWrigley

.github/workflows/ci.yml

@@ -57,6 +57,9 @@ jobs:
       # Cache everything
       - uses: julia-actions/cache@v3
 
+      # - name: Setup tmate session
+      #   uses: mxschmitt/action-tmate@v3
+
       # Run the tests
       - uses: julia-actions/julia-runtest@latest
         with:

src/server.jl

@@ -1250,6 +1250,15 @@ function on_channel_subsystem_request(session, sshchan, subsystem, client)::Bool
     _add_log_event!(client, :channel_subsystem_request, subsystem)
 
     if subsystem == "sftp"
+        # libssh's SFTP server implementation is guarded by a `#ifndef _WIN32`
+        # in src/sftpserver.c, and the Windows stub of
+        # sftp_channel_default_data_callback() returns SSH_ERROR for every
+        # packet. That means we would never reply to the client's SSH_FXP_INIT
+        # and it would block forever in sftp_init(), so fail loudly instead.
+        if Sys.iswindows()
+            throw(LibSSHException("The Demo server doesn't support SFTP on Windows because libssh doesn't implement the SFTP server API there"))
+        end
+
         ptr = lib.sftp_server_new(session, sshchan)
         if ptr == C_NULL
             @error "Call to lib.sftp_server_new() failed"

test/LibSSHTests.jl

@@ -700,9 +700,7 @@ end
             @test_throws ssh.SshProcessFailedException run(`foo`, session)
 
             # Test passing a String instead of a Cmd
-            mktempdir() do tmpdir
-                @test readchomp("cd $(tmpdir) && pwd", session) == tmpdir
-            end
+            @test readchomp("echo foo", session) == "foo"
 
             sshchan = ssh.SshChannel(session)
             close(sshchan)
@@ -778,6 +776,15 @@ end
 end
 
 @testset "SFTP" begin
+    if Sys.iswindows()
+        # libssh doesn't implement the SFTP server API on Windows (the whole
+        # implementation in src/sftpserver.c is inside a `#ifndef _WIN32`, and the
+        # Windows stubs return SSH_ERROR unconditionally), so the DemoServer can't
+        # serve SFTP there and every one of these testsets would hang.
+        @warn "Skipping SFTP tests on windows"
+        return
+    end
+
     @testset "Initialization and finalizing" begin
         demo_server_with_session(2222; verbose=false) do session
             # session.log_verbosity = ssh.SSH_LOG_TRACE
@@ -1238,6 +1245,11 @@ end
 end
 
 @testset "Examples" begin
+    # The examples use the SFTP server, which isn't supported on Windows
+    if Sys.iswindows()
+        return
+    end
+
     mktempdir() do tempdir
         # Test and generate the examples
         Literate.markdown(joinpath(@__DIR__, "../docs/src/examples.jl"),