From 1dbe448a33faf3f2348fa76a70b71fa9d65d08d6 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Thu, 12 Feb 2026 17:17:44 -0500 Subject: [PATCH] Fix JET errors regarding the global `cluster_manager` being defined/undefined MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ``` ┌ @ Distributed /workpath/Distributed.jl/src/process_messages.jl:319 │ `Distributed.cluster_manager` may be undefined: Distributed.cluster_manager └──────────────────── ┌ @ Distributed /workpath/Distributed.jl/src/process_messages.jl:332 │ `Distributed.cluster_manager` may be undefined: Distributed.cluster_manager └──────────────────── ``` We know that the global `cluster_manager` is defined, because it was defined in the `init_worker(...)` function. This commit fixes the JET error. (cherry picked from commit 94de3a2af954453efb6642a4c86f59c9b1f511c0) --- src/process_messages.jl | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/process_messages.jl b/src/process_messages.jl index 6a4b8c2..12a4035 100644 --- a/src/process_messages.jl +++ b/src/process_messages.jl @@ -315,8 +315,12 @@ function handle_msg(msg::ResultMsg, header, r_stream, w_stream, version) end function handle_msg(msg::IdentifySocketMsg, header, r_stream, w_stream, version) + # We know that the global `Distributed.cluster_manager` is defined, because it was defined + # in the `init_worker(...)` function. + @assert isdefined(Distributed, :cluster_manager) # fixes a JET warning + # register a new peer worker connection - w = Worker(msg.from_pid, r_stream, w_stream, cluster_manager; version=version)::Worker + w = Worker(msg.from_pid, r_stream, w_stream, Distributed.cluster_manager; version=version)::Worker send_connection_hdr(w, false) send_msg_now(w, MsgHeader(), IdentifySocketAckMsg()) notify(w.initialized) @@ -328,8 +332,12 @@ function handle_msg(msg::IdentifySocketAckMsg, header, r_stream, w_stream, versi end function handle_msg(msg::JoinPGRPMsg, header, r_stream, w_stream, version) + # We know that the global `cluster_manager` is defined, because it was defined + # in the `init_worker(...)` function. + @assert isdefined(Distributed, :cluster_manager) # fixes a JET warning + LPROC.id = msg.self_pid - controller = Worker(1, r_stream, w_stream, cluster_manager; version=version)::Worker + controller = Worker(1, r_stream, w_stream, Distributed.cluster_manager; version=version)::Worker notify(controller.initialized) register_worker(LPROC) topology(msg.topology)