Hi,
thanks for the great package!
I noticed, that evaluating a PolynomialSystem at a SVector returns an SVector, but the same does not hold true for SizedVector or MVector.
I currently define
for V in [:SizedVector, :MVector ]
@eval Base.@propagate_inbounds StaticPolynomials.evaluate( F :: PolynomialSystem, x :: $V ) = $V( StaticPolynomials._evaluate( F, x ) )
@eval Base.@propagate_inbounds StaticPolynomials.evaluate( F :: PolynomialSystem, x :: $V , p) = $V( StaticPolynomials._evaluate( F, x , p) )
end
in my package, but I think, it would be great to have these definitions in polynomial_system.jl
I guess the other subtypes (FieldVector and SUnitRange) can be neglected.
Should I open a pull request?
Hi,
thanks for the great package!
I noticed, that evaluating a
PolynomialSystemat aSVectorreturns anSVector, but the same does not hold true forSizedVectororMVector.I currently define
in my package, but I think, it would be great to have these definitions in polynomial_system.jl
I guess the other subtypes (
FieldVectorandSUnitRange) can be neglected.Should I open a pull request?