fix: stop the window resizing itself out of control

This was the crash. The window sized itself to the device proportions by reading
innerSize() — physical pixels — and writing it back as a LogicalSize. On a
Retina display those differ by the scale factor, so every run through doubled
the window: 470 wide became 940, then 1880, until the frame filled the screen
and the editor was left rendering into a window several times its size, showing
nothing but background.

The calculation is gone rather than corrected. The device already holds its own
aspect ratio whatever the window does, so a window that does not exactly match
letterboxes it — which is all the resize was ever avoiding, at the price of
fighting the user's own window size.

Author: Jubstaaa

app/src/app.tsx

@@ -1,8 +1,8 @@
-import { LogicalSize, getCurrentWindow } from '@tauri-apps/api/window'
+import { getCurrentWindow } from '@tauri-apps/api/window'
 import { Toaster } from 'sonner'
 import { useCallback, useEffect, useMemo, useReducer, useRef, useState } from 'react'
 
-import { deviceAspect, limitsFrom, windowHeightFor } from './features/editor/editor.constants'
+import { deviceAspect, limitsFrom } from './features/editor/editor.constants'
 import { editorReducer, initialEditorState, toIconState } from './features/editor/editor.reducer'
 import HomeEditor from './features/editor/home-editor'
 import DiffReview from './features/diff-review/diff-review'
@@ -202,20 +202,6 @@ export default function App() {
         getCurrentWindow().setTitle(device ? `${device} — ${system}` : 'IconState')
     }, [device, system])
 
-    useEffect(() => {
-        if (!metrics) return
-        const window_ = getCurrentWindow()
-        window_.innerSize().then(async size => {
-            const factor = await window_.scaleFactor()
-            const logical = size.toLogical(factor)
-            const width = Math.round(logical.width)
-            const wanted = windowHeightFor(metrics, width)
-            if (Math.abs(wanted - Math.round(logical.height)) > 2) {
-                await window_.setSize(new LogicalSize(width, wanted))
-            }
-        })
-    }, [metrics])
-
     return (
         <>
             <HomeEditor

app/src/features/editor/editor.constants.ts

@@ -64,15 +64,8 @@ export const limitsFrom = (metrics: Metrics | null): Limits => {
     }
 }
 
-/** Padding around the device inside the window. */
-const OUTER = 10 * 2
-
 export const deviceAspect = (metrics: Metrics | null): number => {
     const width = metrics?.homeScreenWidth ?? 440
     const height = metrics?.homeScreenHeight ?? 956
     return width / height
 }
-
-/** Window height that leaves no letterboxing around the device. */
-export const windowHeightFor = (metrics: Metrics | null, width: number) =>
-    Math.round((width - OUTER) / deviceAspect(metrics)) + OUTER