Interface change

Author: JoshuaTetzner

README.md

@@ -60,7 +60,7 @@ mesh = meshsphere(1.0, 0.4)
 space = raviartthomas(mesh)
 operator = Maxwell3D.singlelayer(; wavenumber=1.0)
 
-matrix = CFMM.assemble(operator, space)
+matrix = CFMM.assemble(operator, space, space)
 result = matrix * rand(scalartype(operator), numfunctions(space))
 ```
 

docs/src/assets/examples/efie_results.html

@@ -40,7 +40,7 @@ excitation = Maxwell3D.planewave(;
 )
 rhs = assemble((n × excitation) × n, space)
 
-matrix = CFMM.assemble(operator, space)
+matrix = CFMM.assemble(operator, space, space)
 current, stats = Krylov.gmres(
     matrix, rhs; rtol=1.0e-4, itmax=200, history=true, verbose=1
 )

docs/src/assets/examples/mfie_results.html

@@ -16,7 +16,7 @@ operator = Maxwell3D.singlelayer(; wavenumber)
 excitation = Maxwell3D.planewave(; direction=ẑ, polarization=x̂, wavenumber)
 rhs = assemble((n × excitation) × n, space)
 
-matrix = CFMM.assemble(operator, space)
+matrix = CFMM.assemble(operator, space, space)
 current, stats = Krylov.gmres(matrix, rhs; rtol=1.0e-4, itmax=200, history=true, verbose=1)
 
 @show stats

docs/src/manual/examples.md

@@ -20,7 +20,6 @@ using ..CorrectionFactorMatrixMethod:
 
 """
     assemble(operator, testspace, trialspace; kwargs...)
-    assemble(operator, space; kwargs...)
 
 Assemble a matrix-free correction-factor FMM operator.
 
@@ -59,8 +58,4 @@ function assemble(
     )
 end
 
-function assemble(operator, space; kwargs...)
-    return assemble(operator, space, space; kwargs...)
-end
-
 end

examples/efie.jl

@@ -35,11 +35,12 @@
         testoperator(operator, scalarproblems)
     end
 
-    # Single-space convenience form assemble(op, space)
+    # Matching spaces use the symmetric FMM.
     scalar_problem = last(scalarproblems)
+    operator = Helmholtz3D.singlelayer(; wavenumber=k)
     square_matrix = CFMM.assemble(
-        Helmholtz3D.singlelayer(; wavenumber=k), scalar_problem.testspace
+        operator, scalar_problem.testspace, scalar_problem.testspace
     )
-    @test size(square_matrix) ==
-        (length(scalar_problem.testspace), length(scalar_problem.testspace))
+    @test square_matrix.fmm.fmm isa CorrectionFactorMatrixMethod.SymmetricFMM
+    @test_throws MethodError CFMM.assemble(operator, scalar_problem.testspace)
 end