You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #14 (merged). CodeRabbit raised several non-blocking suggestions on the Tabs demo components. Capturing them here so they aren't lost:
Accessibility
Tab15.vue — icon-only TabsTriggers have an aria-hidden icon and no visible text, so screen readers get no accessible name. Add aria-label to each.
Tab14.vue — add aria-label to icon/badge triggers for clarity.
Tab11.vue — overflow-hidden on the active trigger can clip the focus-visible ring; remove it or add an inner focus ring.
Consistency / style
Tab01.vue uses default-value (kebab) while others use defaultValue (camel). Normalize across all demos.
Tab05.vue (and similar) repeat long identical class strings on each trigger; optionally extract to a constant.
Verified non-issues (no action):
Tab12.vue icon imports (HouseIcon, ChartLine, …) — CodeRabbit flagged these as non-existent, but vue-tsc type-check passes, confirming they are valid exports in lucide-vue-next 0.454. No change needed.
Follow-up to #14 (merged). CodeRabbit raised several non-blocking suggestions on the Tabs demo components. Capturing them here so they aren't lost:
Accessibility
Tab15.vue— icon-onlyTabsTriggers have anaria-hiddenicon and no visible text, so screen readers get no accessible name. Addaria-labelto each.Tab14.vue— addaria-labelto icon/badge triggers for clarity.Tab11.vue—overflow-hiddenon the active trigger can clip the focus-visible ring; remove it or add an inner focus ring.Consistency / style
Tab01.vueusesdefault-value(kebab) while others usedefaultValue(camel). Normalize across all demos.Tab05.vue(and similar) repeat long identical class strings on each trigger; optionally extract to a constant.Verified non-issues (no action):
Tab12.vueicon imports (HouseIcon,ChartLine, …) — CodeRabbit flagged these as non-existent, butvue-tsctype-check passes, confirming they are valid exports in lucide-vue-next 0.454. No change needed.src/views/Tabs.vue'React' → 'Vue' description — already fixed in feat: add tabs components #14.