refactor(config): remove unused functions

- Remove getDefaultConfig, mergeWithDefaults (never used)
- Remove getFilesByType export (only used internally)
- Clean up exports and tests

close #32

Author: wishket-pjw

mcp-server/src/config/config.schema.spec.ts

@@ -2,8 +2,6 @@ import { describe, it, expect } from 'vitest';
 import {
   validateConfig,
   parseConfig,
-  getDefaultConfig,
-  mergeWithDefaults,
   isCodingBuddyConfig,
   CodingBuddyConfigSchema,
 } from './config.schema';
@@ -203,59 +201,6 @@ describe('CodingBuddyConfigSchema', () => {
     });
   });
 
-  describe('getDefaultConfig', () => {
-    it('should return empty object as default', () => {
-      const defaults = getDefaultConfig();
-      expect(defaults).toEqual({});
-    });
-  });
-
-  describe('mergeWithDefaults', () => {
-    it('should merge user config with defaults', () => {
-      const userConfig: CodingBuddyConfig = {
-        language: 'ko',
-        projectName: 'my-app',
-      };
-
-      const result = mergeWithDefaults(userConfig);
-      expect(result.language).toBe('ko');
-      expect(result.projectName).toBe('my-app');
-    });
-
-    it('should preserve user config values', () => {
-      const userConfig: CodingBuddyConfig = {
-        techStack: {
-          frontend: ['React'],
-        },
-      };
-
-      const result = mergeWithDefaults(userConfig);
-      expect(result.techStack?.frontend).toEqual(['React']);
-    });
-
-    it('should deep merge nested objects', () => {
-      // Since defaults are empty, this mainly tests that nested objects are preserved
-      const userConfig: CodingBuddyConfig = {
-        techStack: {
-          frontend: ['React'],
-          backend: ['NestJS'],
-        },
-        conventions: {
-          style: 'airbnb',
-          naming: {
-            files: 'kebab-case',
-          },
-        },
-      };
-
-      const result = mergeWithDefaults(userConfig);
-      expect(result.techStack?.frontend).toEqual(['React']);
-      expect(result.techStack?.backend).toEqual(['NestJS']);
-      expect(result.conventions?.style).toBe('airbnb');
-      expect(result.conventions?.naming?.files).toBe('kebab-case');
-    });
-  });
-
   describe('schema type inference', () => {
     it('should correctly infer types from schema', () => {
       const config = CodingBuddyConfigSchema.parse({

mcp-server/src/config/config.schema.ts

@@ -156,47 +156,3 @@ export function isCodingBuddyConfig(value: unknown): value is CodingBuddyConfig
   return CodingBuddyConfigSchema.safeParse(value).success;
 }
 
-/**
- * Get default configuration values
- */
-export function getDefaultConfig(): CodingBuddyConfig {
-  return {};
-}
-
-/**
- * Deep merge utility for nested objects
- */
-function deepMerge<T extends Record<string, unknown>>(target: T, source: T): T {
-  const result = { ...target };
-
-  for (const key of Object.keys(source) as Array<keyof T>) {
-    const sourceValue = source[key];
-    const targetValue = target[key];
-
-    if (
-      sourceValue !== undefined &&
-      typeof sourceValue === 'object' &&
-      sourceValue !== null &&
-      !Array.isArray(sourceValue) &&
-      typeof targetValue === 'object' &&
-      targetValue !== null &&
-      !Array.isArray(targetValue)
-    ) {
-      result[key] = deepMerge(
-        targetValue as Record<string, unknown>,
-        sourceValue as Record<string, unknown>,
-      ) as T[keyof T];
-    } else if (sourceValue !== undefined) {
-      result[key] = sourceValue;
-    }
-  }
-
-  return result;
-}
-
-/**
- * Merge user config with defaults (deep merge)
- */
-export function mergeWithDefaults(userConfig: CodingBuddyConfig): CodingBuddyConfig {
-  return deepMerge(getDefaultConfig(), userConfig);
-}

mcp-server/src/config/context.loader.spec.ts

@@ -2,7 +2,6 @@ import { describe, it, expect } from 'vitest';
 import {
   getContextFileType,
   isLoadableFile,
-  getFilesByType,
   formatContextForAI,
   type ContextFile,
 } from './context.loader';
@@ -62,45 +61,6 @@ describe('context.loader', () => {
     });
   });
 
-  describe('getFilesByType', () => {
-    const mockFiles: ContextFile[] = [
-      { path: 'context/arch.md', content: 'arch', type: 'context', extension: '.md' },
-      { path: 'context/api.md', content: 'api', type: 'context', extension: '.md' },
-      { path: 'prompts/review.md', content: 'review', type: 'prompt', extension: '.md' },
-      { path: 'agents/dev.json', content: '{}', type: 'agent', extension: '.json' },
-      { path: 'readme.md', content: 'readme', type: 'other', extension: '.md' },
-    ];
-
-    it('should filter by context type', () => {
-      const result = getFilesByType(mockFiles, 'context');
-      expect(result).toHaveLength(2);
-      expect(result.map((f) => f.path)).toEqual(['context/arch.md', 'context/api.md']);
-    });
-
-    it('should filter by prompt type', () => {
-      const result = getFilesByType(mockFiles, 'prompt');
-      expect(result).toHaveLength(1);
-      expect(result[0].path).toBe('prompts/review.md');
-    });
-
-    it('should filter by agent type', () => {
-      const result = getFilesByType(mockFiles, 'agent');
-      expect(result).toHaveLength(1);
-      expect(result[0].path).toBe('agents/dev.json');
-    });
-
-    it('should filter by other type', () => {
-      const result = getFilesByType(mockFiles, 'other');
-      expect(result).toHaveLength(1);
-      expect(result[0].path).toBe('readme.md');
-    });
-
-    it('should return empty array for no matches', () => {
-      const result = getFilesByType([], 'context');
-      expect(result).toEqual([]);
-    });
-  });
-
   describe('formatContextForAI', () => {
     it('should format context files correctly', () => {
       const files: ContextFile[] = [

mcp-server/src/config/context.loader.ts

@@ -170,9 +170,9 @@ export async function loadContextFiles(projectRoot: string): Promise<ContextLoad
 }
 
 /**
- * Get context files by type
+ * Get context files by type (internal helper)
  */
-export function getFilesByType(files: ContextFile[], type: ContextFileType): ContextFile[] {
+function getFilesByType(files: ContextFile[], type: ContextFileType): ContextFile[] {
   return files.filter((f) => f.type === type);
 }
 

mcp-server/src/config/index.ts

@@ -34,13 +34,7 @@ export {
 
 export type { ValidationResult, ValidationError } from './config.schema';
 
-export {
-  validateConfig,
-  parseConfig,
-  getDefaultConfig,
-  mergeWithDefaults,
-  isCodingBuddyConfig,
-} from './config.schema';
+export { validateConfig, parseConfig, isCodingBuddyConfig } from './config.schema';
 
 // ============================================================================
 // Config Loader
@@ -82,7 +76,6 @@ export {
   CONTEXT_DIR_NAME,
   KNOWN_SUBDIRS,
   loadContextFiles,
-  getFilesByType,
   formatContextForAI,
   hasContextDir,
 } from './context.loader';