Skip to content

Commit 79d9815

Browse files
committed
fix(ci): ensure Dependabot PRs include yarn.lock updates
Problem: - Dependabot was updating package.json without yarn.lock - canary.yml failed with 'lockfile would have been modified' error - dev.yml incorrectly passed by skipping install on cache hit Solution: - Add versioning-strategy: increase to dependabot.yml for all npm ecosystems - Remove conditional install in dev.yml to always validate lockfile - Add cache step id to canary.yml for consistency This ensures: 1. Dependabot generates complete PRs with lockfile updates 2. Both workflows consistently validate lockfile integrity 3. Out-of-sync dependencies are caught early in CI resolve #284
1 parent e15354d commit 79d9815

3 files changed

Lines changed: 4 additions & 1 deletion

File tree

.github/dependabot.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ updates:
77
interval: 'weekly'
88
day: 'monday'
99
open-pull-requests-limit: 10
10+
versioning-strategy: increase
1011
labels:
1112
- 'dependencies'
1213
- 'security'
@@ -30,6 +31,7 @@ updates:
3031
interval: 'weekly'
3132
day: 'monday'
3233
open-pull-requests-limit: 10
34+
versioning-strategy: increase
3335
labels:
3436
- 'dependencies'
3537
- 'security'
@@ -50,6 +52,7 @@ updates:
5052
interval: 'weekly'
5153
day: 'monday'
5254
open-pull-requests-limit: 10
55+
versioning-strategy: increase
5356
labels:
5457
- 'dependencies'
5558
- 'security'

.github/workflows/canary.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ jobs:
3535
node-version: '24'
3636

3737
- name: Restore dependencies from cache
38+
id: cache
3839
uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
3940
with:
4041
path: |

.github/workflows/dev.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ jobs:
4848
${{ runner.os }}-yarn-
4949
5050
- name: Install dependencies
51-
if: steps.cache.outputs.cache-hit != 'true'
5251
run: yarn install --immutable
5352

5453
# ─────────────── CI Jobs (parallel) ───────────────

0 commit comments

Comments
 (0)