fix(plugin): replace fail() with expect.unreachable() for vitest compat

Author: JeremyDev87

apps/mcp-server/src/plugin/plugin-manifest.schema.spec.ts

@@ -1,3 +1,4 @@
+import { describe, it, expect } from 'vitest';
 import { validatePluginManifest, PluginManifestSchemaError } from './plugin-manifest.schema';
 import type { PluginManifest } from './plugin.types';
 
@@ -123,6 +124,18 @@ describe('PluginManifestSchema', () => {
       expect(() => validatePluginManifest(manifest)).toThrow(PluginManifestSchemaError);
     });
 
+    it('should reject name starting with a digit', () => {
+      const manifest = { ...validManifest, name: '0plugin' };
+
+      expect(() => validatePluginManifest(manifest)).toThrow(PluginManifestSchemaError);
+    });
+
+    it('should reject name with only hyphens', () => {
+      const manifest = { ...validManifest, name: '---' };
+
+      expect(() => validatePluginManifest(manifest)).toThrow(PluginManifestSchemaError);
+    });
+
     it('should reject empty name', () => {
       const manifest = { ...validManifest, name: '' };
 
@@ -156,7 +169,7 @@ describe('PluginManifestSchema', () => {
 
       try {
         validatePluginManifest(manifest);
-        fail('Expected PluginManifestSchemaError');
+        expect.unreachable('Expected PluginManifestSchemaError');
       } catch (error) {
         expect(error).toBeInstanceOf(PluginManifestSchemaError);
         expect((error as PluginManifestSchemaError).message).toContain('name');
@@ -166,7 +179,7 @@ describe('PluginManifestSchema', () => {
     it('should provide actionable error for missing fields', () => {
       try {
         validatePluginManifest({});
-        fail('Expected PluginManifestSchemaError');
+        expect.unreachable('Expected PluginManifestSchemaError');
       } catch (error) {
         expect(error).toBeInstanceOf(PluginManifestSchemaError);
         expect((error as PluginManifestSchemaError).message).toContain('Invalid plugin manifest');

apps/mcp-server/src/plugin/plugin-manifest.schema.ts

@@ -7,7 +7,6 @@
  */
 
 import { z } from 'zod';
-import type { PluginManifest } from './plugin.types';
 
 // ============================================================================
 // Custom Error
@@ -38,7 +37,10 @@ export const PluginManifestSchema = z.object({
   name: z
     .string()
     .min(1)
-    .regex(/^[a-z0-9-]+$/, 'Plugin name must be lowercase alphanumeric with hyphens only'),
+    .regex(
+      /^[a-z][a-z0-9-]*$/,
+      'Plugin name must start with a letter and contain only lowercase alphanumeric with hyphens',
+    ),
   version: z.string().regex(/^\d+\.\d+\.\d+$/, 'Version must be in semver format (e.g. 1.0.0)'),
   description: z.string().min(1),
   author: z.string().min(1),
@@ -47,6 +49,12 @@ export const PluginManifestSchema = z.object({
   provides: PluginProvidesSchema,
 });
 
+// ============================================================================
+// Inferred Type (Single Source of Truth)
+// ============================================================================
+
+export type PluginManifest = z.infer<typeof PluginManifestSchema>;
+
 // ============================================================================
 // Validation Function
 // ============================================================================
@@ -62,7 +70,7 @@ export function validatePluginManifest(json: unknown): PluginManifest {
   const result = PluginManifestSchema.safeParse(json);
 
   if (result.success) {
-    return result.data as PluginManifest;
+    return result.data;
   }
 
   const errorMessage = result.error.issues

apps/mcp-server/src/plugin/plugin.module.ts

@@ -1,4 +1,6 @@
 import { Module } from '@nestjs/common';
 
+// Placeholder: will host PluginRegistryService, PluginInstallService
+// once install/uninstall commands land (Phase 1 follow-up).
 @Module({})
 export class PluginModule {}

apps/mcp-server/src/plugin/plugin.types.ts

@@ -1,7 +1,8 @@
 /**
  * Plugin Manifest Types
  *
- * TypeScript types for plugin.json manifest files used by community plugins.
+ * Re-exports Zod-inferred types as the single source of truth.
+ * Manual interfaces kept for PluginProvides (used independently).
  */
 
 export interface PluginProvides {
@@ -11,12 +12,4 @@ export interface PluginProvides {
   checklists?: string[];
 }
 
-export interface PluginManifest {
-  name: string;
-  version: string;
-  description: string;
-  author: string;
-  tags?: string[];
-  compatibility?: string;
-  provides: PluginProvides;
-}
+export type { PluginManifest } from './plugin-manifest.schema';