Sequence.onsets setter does not allowing slicing

[Jellevanderwerff]

It seems that the following does not work:

seq = thebeat.Sequence.generate_isochronous(10, 500)
seq.onsets[4:8] = seq.onsets[4:8] - 10

[YannickJadoul]

Not sure how to make this work, and if it even is possible with our current implementation:
seq.onsets is a property and creates a new NumPy array, and assigning to this array (or a slice of this array) doesn't trigger the property's setter in any way.

Even this simpler assignment does not work:

seq.onsets[1] = 600

This works:

onsets = seq.onsets
onsets[4:8] = onsets[4:8] - 10
seq.onsets = onsets

[Jellevanderwerff]

Yup that has been my solution so far. Alright, if impossible without convoluted changes then maybe best to just close the issue?

[YannickJadoul]

If it's important, we can have another search? Best option I've come across so far is a very thin wrapper around np.ndarray which would forward changes to onsets to the setter.

Or maybe we should at least think about adding a warning to the docs, if you think this is something users will expect?

[YannickJadoul]

Additional thought.

If we allow this to work:

seq.onsets[1] = 600

Then the following will also work:

onsets = seq.onsets
# Possibly more lines
onsets[1] = 600

I agree the first one is intuitive. I'm not as sure about the second one, though.