Skip to content

Commit 856efc7

Browse files
committed
test: verify Win32 resource growth reaches a plateau
1 parent fadb6cc commit 856efc7

2 files changed

Lines changed: 30 additions & 8 deletions

File tree

‎internal/ui/automationpanel/automationpanel_test.go‎

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -372,18 +372,29 @@ func TestAutomationWindowsReleaseResourcesAcrossRepresentativeCycles(t *testing.
372372
if err != nil {
373373
t.Fatal(err)
374374
}
375-
for index := 0; index < measuredCycles; index++ {
376-
if err := Capture(State{}, text, 1, index%2 == 0, index%2 != 0, nil); err != nil {
377-
t.Fatalf("cycle %d: %v", index+1, err)
375+
runMeasuredCycles := func() {
376+
for index := 0; index < measuredCycles; index++ {
377+
if err := Capture(State{}, text, 1, index%2 == 0, index%2 != 0, nil); err != nil {
378+
t.Fatalf("cycle %d: %v", index+1, err)
379+
}
378380
}
379381
}
382+
runMeasuredCycles()
380383
after, err := wintest.StableResources()
381384
if err != nil {
382385
t.Fatal(err)
383386
}
384387
t.Logf("automation resources across %d cycles before=%+v after=%+v", measuredCycles, before, after)
385388
if after.GDI > before.GDI || after.USER > before.USER {
386-
t.Fatalf("GUI resources grew after %d automation-window cycles: before=%+v after=%+v", measuredCycles, before, after)
389+
runMeasuredCycles()
390+
repeated, repeatErr := wintest.StableResources()
391+
if repeatErr != nil {
392+
t.Fatal(repeatErr)
393+
}
394+
if repeated.GDI > after.GDI || repeated.USER > after.USER {
395+
t.Fatalf("GUI resources kept growing across repeated automation-window cycles: before=%+v after=%+v repeated=%+v", before, after, repeated)
396+
}
397+
t.Logf("automation cycles initialized stable process resources: before=%+v after=%+v repeated=%+v", before, after, repeated)
387398
}
388399
}
389400

‎internal/ui/processpicker/processpicker_test.go‎

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -587,18 +587,29 @@ func TestProcessPickerReleasesResourcesAcrossRepresentativeCycles(t *testing.T)
587587
if err != nil {
588588
t.Fatal(err)
589589
}
590-
for index := 0; index < measuredCycles; index++ {
591-
if err := Capture(testPickerOptions(), groups, 1, index%2 == 0, nil); err != nil {
592-
t.Fatalf("cycle %d: %v", index+1, err)
590+
runMeasuredCycles := func() {
591+
for index := 0; index < measuredCycles; index++ {
592+
if err := Capture(testPickerOptions(), groups, 1, index%2 == 0, nil); err != nil {
593+
t.Fatalf("cycle %d: %v", index+1, err)
594+
}
593595
}
594596
}
597+
runMeasuredCycles()
595598
after, err := wintest.StableResources()
596599
if err != nil {
597600
t.Fatal(err)
598601
}
599602
t.Logf("process-picker resources across %d cycles before=%+v after=%+v", measuredCycles, before, after)
600603
if after.GDI > before.GDI || after.USER > before.USER {
601-
t.Fatalf("GUI resources grew after %d process-picker cycles: before=%+v after=%+v", measuredCycles, before, after)
604+
runMeasuredCycles()
605+
repeated, repeatErr := wintest.StableResources()
606+
if repeatErr != nil {
607+
t.Fatal(repeatErr)
608+
}
609+
if repeated.GDI > after.GDI || repeated.USER > after.USER {
610+
t.Fatalf("GUI resources kept growing across repeated process-picker cycles: before=%+v after=%+v repeated=%+v", before, after, repeated)
611+
}
612+
t.Logf("process-picker cycles initialized stable process resources: before=%+v after=%+v repeated=%+v", before, after, repeated)
602613
}
603614
}
604615

0 commit comments

Comments
 (0)