From bcc5c2a4b4355a8ca13c750a9466e39625ea775a Mon Sep 17 00:00:00 2001 From: Mike DePouw Date: Tue, 26 Nov 2019 11:18:09 -0500 Subject: [PATCH 1/2] Fix Recording Date Serialzation --- src/Id3.Net/Frames/DateTime/RecordingDateFrame.cs | 2 +- test/Id3.Net.Tests/SerializationTests.cs | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Id3.Net/Frames/DateTime/RecordingDateFrame.cs b/src/Id3.Net/Frames/DateTime/RecordingDateFrame.cs index 9c5d372..5621604 100644 --- a/src/Id3.Net/Frames/DateTime/RecordingDateFrame.cs +++ b/src/Id3.Net/Frames/DateTime/RecordingDateFrame.cs @@ -31,7 +31,7 @@ public RecordingDateFrame(DateTime value) : base(value) { } - protected override string DateTimeFormat => "ddMM"; + protected override string DateTimeFormat => "yyyy-MM-dd"; public static implicit operator RecordingDateFrame(DateTime value) => new RecordingDateFrame(value); } diff --git a/test/Id3.Net.Tests/SerializationTests.cs b/test/Id3.Net.Tests/SerializationTests.cs index 2cfea26..b4b2509 100644 --- a/test/Id3.Net.Tests/SerializationTests.cs +++ b/test/Id3.Net.Tests/SerializationTests.cs @@ -17,12 +17,11 @@ limitations under the License. */ #endregion +using Id3.Frames; +using Id3.Serialization; using System; using System.IO; using System.Runtime.Serialization.Formatters.Binary; -using Id3.Frames; -using Id3.Serialization; - using Xunit; namespace Id3.Net.Tests @@ -32,7 +31,8 @@ public sealed class SerializationTests [Fact] public void Serialize_deserialize_test() { - var tag = new Id3Tag { + var tag = new Id3Tag + { Title = "There Will Never Be Another Tonight", Album = "Waking up the neighbors", Track = new TrackFrame(9, 15), From 75e02158e1747181c7dc41f6978bda812a5df450 Mon Sep 17 00:00:00 2001 From: spottedmahn Date: Mon, 16 Dec 2019 11:10:44 -0500 Subject: [PATCH 2/2] Fix Serialization Test --- src/Id3.Net/Frames/DateTime/RecordingDateFrame.cs | 2 +- test/Id3.Net.Tests/SerializationTests.cs | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Id3.Net/Frames/DateTime/RecordingDateFrame.cs b/src/Id3.Net/Frames/DateTime/RecordingDateFrame.cs index 5621604..9c5d372 100644 --- a/src/Id3.Net/Frames/DateTime/RecordingDateFrame.cs +++ b/src/Id3.Net/Frames/DateTime/RecordingDateFrame.cs @@ -31,7 +31,7 @@ public RecordingDateFrame(DateTime value) : base(value) { } - protected override string DateTimeFormat => "yyyy-MM-dd"; + protected override string DateTimeFormat => "ddMM"; public static implicit operator RecordingDateFrame(DateTime value) => new RecordingDateFrame(value); } diff --git a/test/Id3.Net.Tests/SerializationTests.cs b/test/Id3.Net.Tests/SerializationTests.cs index b4b2509..5f3f197 100644 --- a/test/Id3.Net.Tests/SerializationTests.cs +++ b/test/Id3.Net.Tests/SerializationTests.cs @@ -66,7 +66,11 @@ public void Serialize_deserialize_test() Assert.Equal(tag.Year.Value, clonedTag.Year.Value); Assert.Equal(tag.Genre.Value, clonedTag.Genre.Value); Assert.Equal(tag.Publisher.Value, clonedTag.Publisher.Value); - Assert.Equal(tag.RecordingDate.Value, clonedTag.RecordingDate.Value); + + //https://github.com/JeevanJames/Id3/pull/27#issuecomment-565815805 + //TDAT is only day and month + Assert.Equal(tag.RecordingDate.Value.Value.Month, clonedTag.RecordingDate.Value.Value.Month); + Assert.Equal(tag.RecordingDate.Value.Value.Day, clonedTag.RecordingDate.Value.Value.Day); Assert.Equal(tag.Artists.Value.Count, clonedTag.Artists.Value.Count); for (var i = 0; i < tag.Artists.Value.Count; i++)