Skip to content

Investigate + close the config-as-code gap for cultureProfile #4103

Description

@JSONbored

Part of #4092.

Confirmed finding (was originally filed as an open investigation — now resolved by direct code-check)

src/queue/processors.ts (~lines 7160, 9289): isRepoCultureProfileEnabled(env) && args.reviewCultureProfile === truereview.cultureProfile IS already consulted for the real on/off decision, but only as a REQUIRED additional AND-gate alongside GITTENSORY_REVIEW_CULTURE_PROFILE, same pattern as inlineComments/fixHandoff (#4099), reviewMemory (#4101), and impactMap (#4102). A repo can restrict via config but can't fully replace the env var.

Fix

Same shape as #4099/#4101/#4102: apply src/review/feature-activation.ts's existing precedence so review.cultureProfile: true can turn the feature on for a repo even without the env var/allowlist, and false forces it off. Follow whatever namespace decision #4099 makes for consistency.

Deliverables

  • isRepoCultureProfileEnabled's real gate (both call sites) migrated to the resolver's full precedence
  • Regression test: unset config preserves exact current behavior
  • Tests mirroring the feature-activation pattern

Expected outcome

review.cultureProfile fully controls the feature per-repo, consistent with #4099/#4101/#4102.

Effort

S — confirmed, well-defined fix; no further investigation needed.

Metadata

Metadata

Assignees

Labels

maintainer-onlyOwner-only work — yields no Gittensor points.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions