Downloading data from third party source through internet

[J-Y-Yan]

I guess this required internet access?

The app developed for this project should not required internet connection?

[nus-pe-bot]

Team's Response

Use of internet connection for the application is allowed for this module.

This bug is also not related to the quality of documentation.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

• I disagree

Reason for disagreement: I choose documentation bug as this description appears in the documentation bug. But yes, I agree that it is not related to quality of documentation.

However, I believe for this team project, we should keep the internet access minimum. But what I feel from running you app, it takes more than 10 seconds everytime when I start the jar file, which is pretty slow compares with those without internet access.

Also, your app should tackle the situation where there is no internet access. But from what I see from the design of the developer guide, you did not mention this. So I will believe that you did not consider this situation.

What's more, your app seems to solely rely on the data from this thiry-party source, what if one day the source is down?

You also mentioned in the user guide, any wrong result given by the app should blame the source of Nus mods api, but you did not try to correct if any error may cause from using internet access.

So, overall I think relying on internet access on this part could definitely cause some prolems that may affect some users.

---