You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You did a great job so far, well done 👏💪.
However, your project is failing on some linter jobs, but no worries here are some suggestions that might help :
Fixing eslint Errors :
On your terminal try to run this command npx eslint . --fix, this will automatically fix the most of general errors for you.
It's always easy to forget or miss a semicolon, and for that reason the eslint there is a missing semicolon at the end of the feature_card array declaration, to solve that kindly asking to run npx eslint . --fix, or just add a semicolon at the end of the array declaration at line 71.
For style lint please try npx stylelint "here specify the path for CSS files" --fix to fix common error styling.
In style.css file there is an invalid value for margin-top property, so please if there is no need for that, you just can delete it, otherwise ensure to give it proper value 😁.
You have a lot of common styling between the two pages, components like :
Navigation bar
hero section background and styling
Partner or Sponsors section
The footer section.
So to improve that, it's possible to have a separate CSS file that holds the common component styling, then you can link this file to both HTML pages in the head section.
Finally, If you have any questions feel free to comment below in the issue thread.
Happy coding 👏👏👏.
Hi @Iptysam 👋.
You did a great job so far, well done 👏💪.
However, your project is failing on some linter jobs, but no worries here are some suggestions that might help :
Fixing eslint Errors :
On your terminal try to run this command
npx eslint . --fix, this will automatically fix the most of general errors for you.It's always easy to forget or miss a semicolon, and for that reason the
eslintthere is a missing semicolon at the end of thefeature_cardarray declaration, to solve that kindly asking to runnpx eslint . --fix, or just add a semicolon at the end of the array declaration at line 71.Food_recipes/index.js
Line 17 in 15a71f7
Food_recipes/index.js
Line 71 in 15a71f7
Fixing stylelint Errors :
npx stylelint "here specify the path for CSS files" --fixto fix common error styling.style.cssfile there is an invalid value for margin-top property, so please if there is no need for that, you just can delete it, otherwise ensure to give it proper value 😁.Food_recipes/style.css
Line 256 in 15a71f7
To Improve ✨🐱🏍
You have a lot of common styling between the two pages, components like :
Navigation bar
hero section background and styling
Partner or Sponsors section
The footer section.
So to improve that, it's possible to have a separate
CSSfile that holds the common component styling, then you can link this file to bothHTMLpages in theheadsection.Finally, If you have any questions feel free to comment below in the issue thread.
Happy coding 👏👏👏.