From b2124681d026d24f75f156983e400018b1ebc4a8 Mon Sep 17 00:00:00 2001
From: Florian Brandt <florian@brandt.app>
Date: Fri, 2 Oct 2026 23:14:39 +0000
Subject: [PATCH] Don't fail component parsing on unparseable hex colors
 (#3029)

* :bug: fix(gson): Drop unparseable hex colors instead of failing components

Vanilla text components may carry hex colors (#RRGGBB) since 1.16, which
text3 cannot represent. The old TextColorWrapper deserialization threw
JsonParseException and the whole component parse failed.

This drops the unparseable color instead, keeping the text content.
Named colors still parse as before.

* :bug: fix(gson): Log dropped colors at debug level, add license header

Addresses review feedback on #3029: keep the parse-failure stacktrace
available at debug level, and add the GPL header to the new test class.

(cherry picked from commit 1fcbef53918675e3edfdda2cd34214232fe9bf10)
---
 .../text/serializer/gson/StyleSerializer.java | 25 +++++++---
 .../serializer/gson/StyleSerializerTest.java  | 49 +++++++++++++++++++
 2 files changed, 68 insertions(+), 6 deletions(-)
 create mode 100644 worldedit-core/src/test/java/com/sk89q/worldedit/util/formatting/text/serializer/gson/StyleSerializerTest.java

diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/util/formatting/text/serializer/gson/StyleSerializer.java b/worldedit-core/src/main/java/com/sk89q/worldedit/util/formatting/text/serializer/gson/StyleSerializer.java
index 5209ced100..7b98069dbc 100644
--- a/worldedit-core/src/main/java/com/sk89q/worldedit/util/formatting/text/serializer/gson/StyleSerializer.java
+++ b/worldedit-core/src/main/java/com/sk89q/worldedit/util/formatting/text/serializer/gson/StyleSerializer.java
@@ -35,12 +35,14 @@
 import com.sk89q.worldedit.WorldEdit;
 import com.sk89q.worldedit.extension.platform.Capability;
 import com.sk89q.worldedit.internal.Constants;
+import com.sk89q.worldedit.internal.util.LogManagerCompat;
 import com.sk89q.worldedit.util.formatting.text.Component;
 import com.sk89q.worldedit.util.formatting.text.event.ClickEvent;
 import com.sk89q.worldedit.util.formatting.text.event.HoverEvent;
 import com.sk89q.worldedit.util.formatting.text.format.Style;
 import com.sk89q.worldedit.util.formatting.text.format.TextColor;
 import com.sk89q.worldedit.util.formatting.text.format.TextDecoration;
+import org.apache.logging.log4j.Logger;
 
 import java.lang.reflect.Type;
 
@@ -48,6 +50,8 @@
 public class StyleSerializer implements JsonDeserializer<Style>, JsonSerializer<Style> {
     public static final StyleSerializer INSTANCE = new StyleSerializer();
 
+    private static final Logger LOGGER = LogManagerCompat.getLogger();
+
     private static final TextDecoration[] DECORATIONS = TextDecoration.values();
 
     static final boolean PRE_1215;
@@ -85,12 +89,21 @@ private Style deserialize(final JsonObject json, final JsonDeserializationContex
         final Style.Builder style = Style.builder();
 
         if (json.has(COLOR)) {
-            final TextColorWrapper color = context.deserialize(json.get(COLOR), TextColorWrapper.class);
-            if (color.color != null) {
-                style.color(color.color);
-            } else if (color.decoration != null) {
-                // I know. Setting a decoration from the color is weird. This is, unfortunately, something we need to support.
-                style.decoration(color.decoration, true);
+            TextColorWrapper color = null;
+            try {
+                color = context.deserialize(json.get(COLOR), TextColorWrapper.class);
+            } catch (JsonParseException e) {
+                // Vanilla text components may carry hex colors (#RRGGBB) since 1.16, text3 cannot represent them.
+                // Drop the color instead of failing to parse the whole component.
+                LOGGER.debug("Failed to parse component color, dropping it", e);
+            }
+            if (color != null) {
+                if (color.color != null) {
+                    style.color(color.color);
+                } else if (color.decoration != null) {
+                    // I know. Setting a decoration from the color is weird. This is, unfortunately, something we need to support.
+                    style.decoration(color.decoration, true);
+                }
             }
         }
 
diff --git a/worldedit-core/src/test/java/com/sk89q/worldedit/util/formatting/text/serializer/gson/StyleSerializerTest.java b/worldedit-core/src/test/java/com/sk89q/worldedit/util/formatting/text/serializer/gson/StyleSerializerTest.java
new file mode 100644
index 0000000000..94dfbd5a94
--- /dev/null
+++ b/worldedit-core/src/test/java/com/sk89q/worldedit/util/formatting/text/serializer/gson/StyleSerializerTest.java
@@ -0,0 +1,49 @@
+/*
+ * WorldEdit, a Minecraft world manipulation toolkit
+ * Copyright (C) sk89q <http://www.sk89q.com>
+ * Copyright (C) WorldEdit team and contributors
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+package com.sk89q.worldedit.util.formatting.text.serializer.gson;
+
+import com.sk89q.worldedit.util.formatting.text.Component;
+import com.sk89q.worldedit.util.formatting.text.TextComponent;
+import com.sk89q.worldedit.util.formatting.text.format.TextColor;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+class StyleSerializerTest {
+
+    @Test
+    void hexColorIsDroppedInsteadOfFailing() {
+        // Vanilla item names may carry hex colors ("#RRGGBB") since 1.16, text3 cannot represent them.
+        Component hexOnly = GsonComponentSerializer.INSTANCE.deserialize(
+                "{\"text\":\"Gold item\",\"color\":\"#FFD700\"}"
+        );
+        assertEquals("Gold item", ((TextComponent) hexOnly).content());
+        assertNull(hexOnly.color());
+    }
+
+    @Test
+    void namedColorStillParsed() {
+        Component component = GsonComponentSerializer.INSTANCE.deserialize(
+                "{\"text\":\"Gold item\",\"color\":\"gold\"}"
+        );
+        assertEquals(TextColor.GOLD, component.color());
+    }
+}