Skip to content

API: ignore dataAddedSince parameter when until is not "unlimited" #23

Description

@salcock

There is a bug in libbgpstream where all follow-up requests to a paginated response have the dataAddedSince parameter included and set to the wall time when the previous paginated response was received.

This means that essentially any request for historical data through bgpstream that gets paginated by our broker will, by default, begin returning empty results after the first page.

It appears that the CAIDA broker ignores the dataAddedSince parameter under these circumstances (if not all circumstances), whereas our implementation naturally assumes that the query parameters provided are an accurate reflection of what the user really wants.

I've fixed the bug in our branch of libbgpstream, but that won't be of much help when users turn up using the current CAIDA release and wonder why their programs stop running for no apparent reason.

Most likely, this means that we will need to try and duplicate the CAIDA behavior by effectively ignoring dataAddedSince if the request also specifies a specific until timestamp (as presumably that is a user doing a historical fetch rather than trying to "live stream" BGP data).

Metadata

Metadata

Assignees

No one assigned

    Labels

    interoperabilityNeed to resolve to be compatible with bgpstream

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions