Commit 20a862f
committed
[jaxrs-spec] Add records samples for every library and build them in CI
useRecords is implemented in the shared model/record templates, so it applies
to all five jaxrs-spec libraries, but only the default one had a sample. Add a
records sample per library - helidon, kumuluzee, openliberty, quarkus and
thorntail - and register all five in the JDK17 samples workflow so they are
compiled on every push and pull request.
Two things had to be fixed to make those samples compile:
* Each library overrides pom.mustache and hardcoded Java 1.8 (helidon: 11), so
a records or sealed sample could not build. Gate the compiler source/target
on useSealed/useRecords exactly as the base pom.mustache already does.
* record.mustache imported JsonNullable unconditionally. The import is already
contributed through the imports block for the models that use it, so records
with a nullable component carried a duplicate import, and records without one
carried an unused import that fails to compile on the libraries whose pom
does not ship jackson-databind-nullable.
kumuluzee, openliberty and thorntail additionally set openApiNullable=false in
their sample config: their poms omit jackson-databind-nullable while the pojo
template imports JsonNullable whenever openApiNullable is on, which is a
pre-existing issue unrelated to records (it reproduces with no records flags
set at all).
All six records samples plus jaxrs-spec-sealed build under JDK 17.1 parent e621e73 commit 20a862f
98 files changed
Lines changed: 3106 additions & 14 deletions
File tree
- .github/workflows
- bin/configs
- modules/openapi-generator/src
- main/resources/JavaJaxRS/spec
- libraries
- helidon
- kumuluzee
- openliberty
- quarkus
- thorntail
- test/java/org/openapitools/codegen/java/jaxrs
- samples/server/petstore
- jaxrs-spec-records-helidon
- .openapi-generator
- src
- gen/java/org/openapitools
- api
- model
- main/resources
- META-INF
- jaxrs-spec-records-kumuluzee
- .openapi-generator
- src/main
- java/org/openapitools
- api
- model
- resources
- META-INF
- jaxrs-spec-records-openliberty
- .openapi-generator
- src
- gen/java/org/openapitools
- api
- model
- main
- liberty/config
- webapp
- META-INF
- WEB-INF
- jaxrs-spec-records-quarkus
- .openapi-generator
- src
- gen/java/org/openapitools
- api
- model
- main
- docker
- resources
- META-INF
- jaxrs-spec-records-thorntail
- .openapi-generator
- src
- gen/java/org/openapitools
- api
- model
- main/resources/META-INF
- jaxrs-spec-records/src/gen/java/org/openapitools/model
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
27 | 32 | | |
28 | 33 | | |
29 | 34 | | |
| |||
48 | 53 | | |
49 | 54 | | |
50 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
51 | 61 | | |
52 | 62 | | |
53 | 63 | | |
| |||
78 | 88 | | |
79 | 89 | | |
80 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
81 | 96 | | |
82 | 97 | | |
83 | 98 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
| 23 | + | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
| 54 | + | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
| 21 | + | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
0 commit comments