From 766fc503494b9f426357657b9ef581c20087473a Mon Sep 17 00:00:00 2001 From: Ashwani Yadav <22ashwaniyadav@gmail.com> Date: Sat, 29 Aug 2026 15:10:43 +0530 Subject: [PATCH] a11y: Fix wrong content descriptions in settings dialogs The language lists in the Preferred Website Languages dialog announced the app name to TalkBack, and the popup exceptions list announced a raw resource name missing its @string/ prefix. --- app/src/main/res/layout/options_exceptions.xml | 2 +- app/src/main/res/layout/options_language_content.xml | 4 ++-- app/src/main/res/values/strings.xml | 8 ++++++++ 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/app/src/main/res/layout/options_exceptions.xml b/app/src/main/res/layout/options_exceptions.xml index 7faf316ac9..f7dbcb9c53 100644 --- a/app/src/main/res/layout/options_exceptions.xml +++ b/app/src/main/res/layout/options_exceptions.xml @@ -89,7 +89,7 @@ style="@style/customRecyclerViewStyle" android:layout_width="match_parent" android:layout_height="match_parent" - android:contentDescription="privacy_options_popups_list_header_v1" + android:contentDescription="@string/privacy_options_popups_list_header_v1" android:paddingEnd="15dp" app:layoutManager="LinearLayoutManager" /> diff --git a/app/src/main/res/layout/options_language_content.xml b/app/src/main/res/layout/options_language_content.xml index ce7918c49a..2d5db96ad9 100644 --- a/app/src/main/res/layout/options_language_content.xml +++ b/app/src/main/res/layout/options_language_content.xml @@ -52,7 +52,7 @@ android:paddingEnd="15dp" android:layout_width="match_parent" android:layout_height="match_parent" - android:contentDescription="@string/app_name" + android:contentDescription="@string/language_options_preferred_languages_content_description" app:layoutManager="LinearLayoutManager" /> @@ -76,7 +76,7 @@ android:paddingEnd="15dp" android:layout_width="match_parent" android:layout_height="match_parent" - android:contentDescription="@string/app_name" + android:contentDescription="@string/language_options_available_languages_content_description" app:layoutManager="LinearLayoutManager" /> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index e880161431..e82e4cbf9f 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -1724,6 +1724,14 @@ Available Languages + + List of preferred languages + + + List of available languages + Name