hyperacc/policy_test.go at master · IceTweak/hyperacc · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
package hyperacc

import (
	"testing"

	"github.com/stretchr/testify/assert"

	"github.com/IceTweak/hyperacc/mocks"
)

func TestPolicySet_DefaultRules(t *testing.T) {
	t.Run("no default rules and no specific policy - access granted", func(t *testing.T) {
		ctxMock := new(mocks.MockTransactionContextInterface)
		ps := NewPolicySet()

		err := ps.Check(ctxMock, "CreateAsset")
		assert.NoError(t, err)
		ctxMock.AssertExpectations(t)
	})

	t.Run("default rules applied when no specific policy exists", func(t *testing.T) {
		ctxMock, identityMock := setupMocks()
		identityMock.On("GetMSPID").Return("Org1MSP", nil)

		ps := NewPolicySet(RequireMSPID("Org1MSP"))
		err := ps.Check(ctxMock, "CreateAsset")

		assert.NoError(t, err)
		ctxMock.AssertExpectations(t)
		identityMock.AssertExpectations(t)
	})

	t.Run("default rules deny when not matched", func(t *testing.T) {
		ctxMock, identityMock := setupMocks()
		identityMock.On("GetMSPID").Return("Org2MSP", nil)

		ps := NewPolicySet(RequireMSPID("Org1MSP"))
		err := ps.Check(ctxMock, "CreateAsset")

		assert.Error(t, err)
		ctxMock.AssertExpectations(t)
		identityMock.AssertExpectations(t)
	})
}

func TestPolicySet_SpecificPolicy(t *testing.T) {
	t.Run("specific policy overrides defaults", func(t *testing.T) {
		ctxMock, identityMock := setupMocks()
		identityMock.On("GetAttributeValue", "role").Return("admin", true, nil)

		ps := NewPolicySet(RequireMSPID("Org1MSP"))
		ps.AddPolicy("CreateAsset", RequireRole("admin"))
		err := ps.Check(ctxMock, "CreateAsset")

		assert.NoError(t, err)
		ctxMock.AssertExpectations(t)
		identityMock.AssertExpectations(t)
	})

	t.Run("specific policy denies", func(t *testing.T) {
		ctxMock, identityMock := setupMocks()
		identityMock.On("GetAttributeValue", "role").Return("user", true, nil)

		ps := NewPolicySet()
		ps.AddPolicy("DeleteAsset", RequireRole("admin"))
		err := ps.Check(ctxMock, "DeleteAsset")

		assert.Error(t, err)
		ctxMock.AssertExpectations(t)
		identityMock.AssertExpectations(t)
	})

	t.Run("multiple functions with different policies", func(t *testing.T) {
		ctxMock, identityMock := setupMocks()
		identityMock.On("GetAttributeValue", "role").Return("admin", true, nil)

		ps := NewPolicySet(RequireMSPID("Org1MSP"))
		ps.AddPolicy("CreateAsset", RequireRole("admin"))
		ps.AddPolicy("ReadAsset", RequireRole("user"))

		// CreateAsset should pass (admin role)
		err := ps.Check(ctxMock, "CreateAsset")
		assert.NoError(t, err)

		// ReadAsset should fail (admin role, not user)
		err = ps.Check(ctxMock, "ReadAsset")
		assert.Error(t, err)
	})
}

func TestPolicySet_RemovePolicy(t *testing.T) {
	t.Run("removed policy falls back to defaults", func(t *testing.T) {
		ctxMock, identityMock := setupMocks()
		identityMock.On("GetMSPID").Return("Org1MSP", nil)

		ps := NewPolicySet(RequireMSPID("Org1MSP"))
		ps.AddPolicy("CreateAsset", RequireRole("admin"))
		ps.RemovePolicy("CreateAsset")

		err := ps.Check(ctxMock, "CreateAsset")
		assert.NoError(t, err)
		ctxMock.AssertExpectations(t)
		identityMock.AssertExpectations(t)
	})
}

func TestPolicySet_Middleware(t *testing.T) {
	t.Run("middleware wraps policy check for function", func(t *testing.T) {
		ctxMock, identityMock := setupMocks()
		identityMock.On("GetAttributeValue", "role").Return("admin", true, nil)

		ps := NewPolicySet()
		ps.AddPolicy("CreateAsset", RequireRole("admin"))
		mw := ps.Middleware("CreateAsset")

		err := mw(ctxMock)
		assert.NoError(t, err)
		ctxMock.AssertExpectations(t)
		identityMock.AssertExpectations(t)
	})

	t.Run("middleware returns error on denial", func(t *testing.T) {
		ctxMock, identityMock := setupMocks()
		identityMock.On("GetAttributeValue", "role").Return("user", true, nil)

		ps := NewPolicySet()
		ps.AddPolicy("CreateAsset", RequireRole("admin"))
		mw := ps.Middleware("CreateAsset")

		err := mw(ctxMock)
		assert.Error(t, err)
		ctxMock.AssertExpectations(t)
		identityMock.AssertExpectations(t)
	})
}

func TestPolicySet_ChainableAPI(t *testing.T) {
	t.Run("AddPolicy returns PolicySet for chaining", func(t *testing.T) {
		ps := NewPolicySet()
		ps2 := ps.AddPolicy("CreateAsset", RequireRole("admin"))
		assert.Same(t, ps, ps2)
	})

	t.Run("RemovePolicy returns PolicySet for chaining", func(t *testing.T) {
		ps := NewPolicySet()
		ps.AddPolicy("CreateAsset", RequireRole("admin"))
		ps2 := ps.RemovePolicy("CreateAsset")
		assert.Same(t, ps, ps2)
	})
}