From 08b1841bd7ac008f2ce0287cb12b8f61dfc47e6b Mon Sep 17 00:00:00 2001
From: "Misha M.-Kupriyanov" <kupriyanov@strato.de>
Date: Wed, 13 May 2026 17:14:31 +0200
Subject: [PATCH] ci: remove duplicate psalm workflow

Two workflow files (.github/workflows/psalm.yml and psalm-matrix.yml)
both declared `name: Static analysis` and shared the same concurrency
group `psalm-${{ github.head_ref || github.run_id }}` with
`cancel-in-progress: true`. Whichever workflow GitHub scheduled second
cancelled the first. When the matrix workflow lost the race, its
summary job (`if: always()`, `exit 1` when not success) saw the
cancellation and produced a red `static-psalm-analysis-summary` check
on every PR, even when psalm itself passed.

Drop psalm.yml and keep psalm-matrix.yml: the matrix variant runs psalm
against every supported nextcloud/ocp version with the matching php-min
and includes the summary aggregate job intended for branch protection.

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
---
 .github/workflows/psalm.yml | 62 -------------------------------------
 1 file changed, 62 deletions(-)
 delete mode 100644 .github/workflows/psalm.yml

diff --git a/.github/workflows/psalm.yml b/.github/workflows/psalm.yml
deleted file mode 100644
index 9fa1b66..0000000
--- a/.github/workflows/psalm.yml
+++ /dev/null
@@ -1,62 +0,0 @@
-# This workflow is provided via the organization template repository
-#
-# https://github.com/nextcloud/.github
-# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
-#
-# SPDX-FileCopyrightText: 2022-2024 Nextcloud GmbH and Nextcloud contributors
-# SPDX-License-Identifier: MIT
-
-name: Static analysis
-
-on: pull_request
-
-concurrency:
-  group: psalm-${{ github.head_ref || github.run_id }}
-  cancel-in-progress: true
-
-permissions:
-  contents: read
-
-jobs:
-  static-analysis:
-    runs-on: ubuntu-latest
-
-    name: static-psalm-analysis
-    steps:
-      - name: Checkout
-        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
-        with:
-          persist-credentials: false
-
-      - name: Get php version
-        id: versions
-        uses: icewind1991/nextcloud-version-matrix@58becf3b4bb6dc6cef677b15e2fd8e7d48c0908f # v1.3.1
-
-      - name: Check enforcement of minimum PHP version ${{ steps.versions.outputs.php-min }} in psalm.xml
-        run: grep 'phpVersion="${{ steps.versions.outputs.php-min }}' psalm.xml
-
-      - name: Set up php${{ steps.versions.outputs.php-available }}
-        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2.36.0
-        with:
-          php-version: ${{ steps.versions.outputs.php-available }}
-          extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
-          coverage: none
-          ini-file: development
-          # Temporary workaround for missing pcntl_* in PHP 8.3
-          ini-values: disable_functions=
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Install dependencies
-        run: |
-          composer remove nextcloud/ocp --dev --no-scripts
-          composer i
-
-      - name: Check for vulnerable PHP dependencies
-        run: composer require --dev roave/security-advisories:dev-latest
-
-      - name: Install nextcloud/ocp
-        run: composer require --dev nextcloud/ocp:dev-${{ steps.versions.outputs.branches-max }} --ignore-platform-reqs --with-dependencies
-
-      - name: Run coding standards check
-        run: composer run psalm -- --threads=1 --monochrome --no-progress --output-format=github