From 6f56ae9d8c13bebe64d665ce567e55bbb2fc03e7 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 26 Oct 2022 03:17:49 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- pyvospace/server/spaces/posix/utils.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/pyvospace/server/spaces/posix/utils.py b/pyvospace/server/spaces/posix/utils.py index 37cd185..2b3e8c4 100644 --- a/pyvospace/server/spaces/posix/utils.py +++ b/pyvospace/server/spaces/posix/utils.py @@ -217,7 +217,26 @@ def untar(tar_name, extract_dir, target, storage): os.makedirs(extract_dir) with tarfile.open(tar_name) as tar: - tar.extractall(path=extract_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=extract_dir) return path_to_node_tree(extract_dir, target.path, target.owner, target.group_read, target.group_write, storage)