Better editing commands: cursor and navigation

[blame19]

Editing a command can be tricky.

From my understanding, Ctrl+E activates the editing mode of a previously hoarded command, which is great. However, when down in Editing, it's not possible to see a cursor of any kind on the interface. Furthermore, the only actions supported seem to be:

• deleting characters starting from the end of the line
• writing from the end of the line
  (Feel free to correct me if I'm wrong)

Since hoard was born to store pretty complex commands, I can imagine in most use cases the stored commands are long. It would be inconvenient to cancel and retype an hoarded command during editing - an user might just as well delete and recreate it.
This can be solved by:

• adding a cursor to the editing view
• allowing navigation, so to pin-point edit

[Hyde46]

Great points, thanks a lot for your perspective!
I've planned to rewrite the UI anyways and will incorporate your input 🙂

[croissong]

Alternatively, I would prefer the option to simply edit the command in my $EDITOR :)

[Hyde46]

Great addition @croissong . Keeping that in mind, when i finally get some time to work on this!

[Hyde46]

@croissong I played around with some options to let people use their own editor. Unfortunately when running hoard with the TUI, most terminal editors are quite unhappy with whats happening to the different pipes.
Still, i'm adding a hoard edit-trove command to quickly open the main trove.yml file which contains all the commands.
Maybe i'll find a better solution until the big refactor is done

(Better inline editing will still be part of all that)

[croissong]

Unfortunately when running hoard with the TUI, most terminal editors are quite unhappy with whats happening to the different pipes.

Just in case it might help, the-way also uses dialoguer and uses dialoguer::Editor to open the editor: external_editor_input.
It works well for me with emacs & vim.