fix(tui): repair PR #5726 gate surface — clippy, accounting and wire-route tests

CI-form clippy repairs on the checkpoint head:
- box MailboxMessage::TokenUsage.route (large_enum_variant) with call-site
  and test updates in subagent_routing and mailbox
- needless_return in session_manager lock-file open, doc_lazy_continuation
  in translation, obfuscated_if_else in provider_lake
- route resolver + provider lake alignment for the opencode_zen wire-route
  expectations (Responses/AnthropicMessages vs ChatCompletions)

Verified locally:
- cargo test -p codewhale-tui --locked --lib: 11596 passed, 6 failed — the 6
  are the pre-existing main-baseline sandbox::read_guard symlink family that
  #5724 makes whole-fn-unix; zero Slice-A regressions
- auto_review_guardian family 7/7 (accounting + denial + cache replay)
- web vitest run of crates/tui/src/runtime_web/app.test.mjs: 28/28
- CI-form clippy clean (previous session)

Signed-off-by: CodeWhale Bot <bot@codewhale.net>

Author: CodeWhale Bot

crates/config/src/route/resolver.rs

@@ -259,12 +259,16 @@ impl RouteResolver {
             // Capabilities and pricing belong to the exact provider endpoint
             // offering that reported them. Reusing a provider enum and a
             // first-party model id against a custom compatible endpoint does
-            // not prove that proxy serves the same canonical model, protocol,
-            // limits, modality, tool, reasoning, or billing contract. Keep the
+            // not prove that proxy serves the same canonical model, limits,
+            // modality, tool, reasoning, or billing contract. Keep the
             // caller's wire model id, but clear every unowned offering fact at
             // the authority boundary instead of presenting it as verified.
+            // The endpoint_key/protocol stays: it is the provider adapter's
+            // wire contract (a model-aware roster row or fixed policy), not an
+            // endpoint-catalog fact, and coercing it to Chat would silently
+            // change how a Responses- or Messages-bound route speaks.
+            // Deepseek's custom-endpoint Chat pass-through is handled above.
             selected.canonical_model = None;
-            selected.endpoint_key = "chat".to_string();
             selected.limits = RouteLimits::default();
             selected.capabilities = RouteCapabilities::default();
             selected.pricing = PricingSku::UnknownOrStale;

crates/tui/src/core/engine/tests.rs

@@ -4102,14 +4102,14 @@ fn subagent_mailbox_keeps_lifecycle_events_reliable() {
         &MailboxMessage::TokenUsage {
             agent_id: "agent_a".to_string(),
             source_id: "response-a".to_string(),
-            route: crate::cost_status::EffectiveRouteEnvelope::capture(
+            route: Box::new(crate::cost_status::EffectiveRouteEnvelope::capture(
                 None,
                 ApiProvider::Deepseek,
                 "deepseek",
                 "model",
                 Some(ApiProvider::Deepseek.default_base_url()),
                 chrono::Utc::now(),
-            ),
+            )),
             usage: Usage::default(),
         }
     ));
@@ -4196,14 +4196,14 @@ fn subagent_mailbox_never_samples_lifecycle_or_usage_events() {
         &MailboxMessage::TokenUsage {
             agent_id: "agent_a".to_string(),
             source_id: "response-a".to_string(),
-            route: crate::cost_status::EffectiveRouteEnvelope::capture(
+            route: Box::new(crate::cost_status::EffectiveRouteEnvelope::capture(
                 None,
                 ApiProvider::Deepseek,
                 "deepseek",
                 "model",
                 Some(ApiProvider::Deepseek.default_base_url()),
                 chrono::Utc::now(),
-            ),
+            )),
             usage: Usage::default(),
         },
         start,
@@ -5659,8 +5659,11 @@ async fn normal_repl_kernel_persists_across_user_turns() {
     assert_eq!(first_turn.usage.output_tokens, 11);
     let child_usage_event = {
         let mut events = handle.rx_event.write().await;
+        // Kernel child calls carry their own routed cost receipt, so their
+        // per-call telemetry arrives as `RoutedTurnUsage` rather than the
+        // parent-route `TurnUsage` receipt.
         std::iter::from_fn(|| events.try_recv().ok()).find_map(|event| match event {
-            Event::TurnUsage { usage, .. }
+            Event::RoutedTurnUsage { usage, .. }
                 if usage.input_tokens == 7 && usage.output_tokens == 11 =>
             {
                 Some(usage)
@@ -7395,7 +7398,12 @@ async fn collect_guardian_journey_with_receipts(
                     "duplicate tool result"
                 );
             }
-            Event::TurnUsage { usage, .. } => usage_events.push(usage),
+            // Guardian consults carry their own routed receipt; both the
+            // parent-route and routed per-call telemetry count as reaching
+            // the cost UI.
+            Event::TurnUsage { usage, .. } | Event::RoutedTurnUsage { usage, .. } => {
+                usage_events.push(usage);
+            }
             Event::ToolGateDecision {
                 tool_id,
                 gate,

crates/tui/src/provider_lake.rs

@@ -586,28 +586,28 @@ pub(crate) fn runtime_catalog_resolver_for_identity(
         if !exact_matches && let LivePartitionOwner::BuiltIn(identity) = &partition_owner {
             authoritative.remove(identity);
         }
-        let fallback = (provider != ApiProvider::Custom)
-            .then(|| {
-                live.models_dev
-                    .as_ref()
-                    .map(|models_dev| {
-                        models_dev
-                            .offerings
-                            .iter()
-                            .filter(|row| catalog_partition_key(&row.provider) == catalog_key)
-                            .cloned()
-                            .collect::<Vec<_>>()
-                    })
-                    .unwrap_or_default()
-            })
-            .unwrap_or_default();
-        let custom_rows = (provider == ApiProvider::Custom && exact_matches)
-            .then(|| {
-                exact_partition
-                    .map(|partition| partition.offerings.clone())
-                    .unwrap_or_default()
-            })
-            .unwrap_or_default();
+        let fallback = if provider == ApiProvider::Custom {
+            Vec::new()
+        } else {
+            live.models_dev
+                .as_ref()
+                .map(|models_dev| {
+                    models_dev
+                        .offerings
+                        .iter()
+                        .filter(|row| catalog_partition_key(&row.provider) == catalog_key)
+                        .cloned()
+                        .collect::<Vec<_>>()
+                })
+                .unwrap_or_default()
+        };
+        let custom_rows = if provider == ApiProvider::Custom && exact_matches {
+            exact_partition
+                .map(|partition| partition.offerings.clone())
+                .unwrap_or_default()
+        } else {
+            Vec::new()
+        };
         (exact_matches, authoritative, fallback, custom_rows)
     } else {
         (

crates/tui/src/runtime_threads.rs

@@ -8894,7 +8894,10 @@ impl RuntimeThreadManager {
                         self.append_routed_usage_to_turn(
                             &turn_id,
                             &source_id,
-                            EffectiveRouteUsage { route, usage },
+                            EffectiveRouteUsage {
+                                route: *route,
+                                usage,
+                            },
                         )?;
                     }
                 }

crates/tui/src/runtime_threads/tests.rs

@@ -5962,7 +5962,7 @@ async fn monitor_separates_lifecycle_start_from_billing_dispatch_and_child_usage
             message: crate::tools::subagent::MailboxMessage::TokenUsage {
                 agent_id: "agent_child".to_string(),
                 source_id: "response-child".to_string(),
-                route: crate::cost_status::EffectiveRouteEnvelope {
+                route: Box::new(crate::cost_status::EffectiveRouteEnvelope {
                     provider: ApiProvider::OpenaiCodex,
                     provider_identity: "codex-child".to_string(),
                     model: "gpt-5.5".to_string(),
@@ -5973,7 +5973,7 @@ async fn monitor_separates_lifecycle_start_from_billing_dispatch_and_child_usage
                     provider_live_pricing: None,
                     billing_mode: crate::cost_status::RouteBillingMode::Subscription,
                     dispatched_at,
-                },
+                }),
                 usage: Usage {
                     input_tokens: 3,
                     output_tokens: 2,
@@ -6106,7 +6106,7 @@ async fn monitor_separates_lifecycle_start_from_billing_dispatch_and_child_usage
             message: crate::tools::subagent::MailboxMessage::TokenUsage {
                 agent_id: "agent-child-second".to_string(),
                 source_id: "response-child-second".to_string(),
-                route: crate::cost_status::EffectiveRouteEnvelope {
+                route: Box::new(crate::cost_status::EffectiveRouteEnvelope {
                     provider: ApiProvider::OpenaiCodex,
                     provider_identity: "codex-child".to_string(),
                     model: "gpt-5.5".to_string(),
@@ -6117,7 +6117,7 @@ async fn monitor_separates_lifecycle_start_from_billing_dispatch_and_child_usage
                     provider_live_pricing: None,
                     billing_mode: crate::cost_status::RouteBillingMode::Subscription,
                     dispatched_at: Utc::now(),
-                },
+                }),
                 usage: Usage {
                     input_tokens: 5,
                     output_tokens: 1,

crates/tui/src/session_manager.rs

@@ -124,7 +124,7 @@ fn open_private_lock_file(path: &Path) -> io::Result<fs::File> {
         let file = options.open(path)?;
         validate_private_regular_file(&file, path)?;
         file.set_permissions(fs::Permissions::from_mode(0o600))?;
-        return Ok(file);
+        Ok(file)
     }
     #[cfg(windows)]
     {
@@ -133,7 +133,7 @@ fn open_private_lock_file(path: &Path) -> io::Result<fs::File> {
         options.custom_flags(FILE_FLAG_OPEN_REPARSE_POINT);
         let file = options.open(path)?;
         validate_private_regular_file(&file, path)?;
-        return Ok(file);
+        Ok(file)
     }
     #[cfg(all(not(unix), not(windows)))]
     {

crates/tui/src/tools/subagent/mailbox.rs

@@ -84,8 +84,9 @@ pub enum MailboxMessage {
         /// this across direct durability, mailbox replay, and restart dedupe.
         source_id: String,
         /// Immutable provider/model/billing evidence captured before the
-        /// child request was sent.
-        route: crate::cost_status::EffectiveRouteEnvelope,
+        /// child request was sent. Boxed: the envelope dwarfs every other
+        /// variant, and mailboxes queue many messages.
+        route: Box<crate::cost_status::EffectiveRouteEnvelope>,
         /// Provider usage payload, including cache-hit/cache-miss fields.
         usage: Usage,
     },
@@ -141,7 +142,7 @@ impl MailboxMessage {
         Self::TokenUsage {
             agent_id: agent_id.into(),
             source_id: source_id.into(),
-            route,
+            route: Box::new(route),
             usage,
         }
     }
@@ -618,7 +619,7 @@ mod tests {
                 MailboxMessage::TokenUsage {
                     agent_id: "a9".into(),
                     source_id: "response-a9".into(),
-                    route: test_route(ApiProvider::Deepseek, "deepseek-v4-flash"),
+                    route: Box::new(test_route(ApiProvider::Deepseek, "deepseek-v4-flash")),
                     usage: Usage {
                         input_tokens: 100,
                         output_tokens: 50,

crates/tui/src/tools/subagent/tests.rs

@@ -20902,6 +20902,19 @@ mod child_permission_gate {
     #[cfg(not(windows))]
     const GUARDIAN_PIPELINE: &str = "echo built | cat";
 
+    /// [`GUARDIAN_PIPELINE`] with a caller-chosen marker, for tests that
+    /// need to recognize their own output.
+    fn guardian_marker_pipeline(marker: &str) -> String {
+        #[cfg(windows)]
+        {
+            format!("echo {marker} | Out-String")
+        }
+        #[cfg(not(windows))]
+        {
+            format!("echo {marker} | cat")
+        }
+    }
+
     #[tokio::test]
     async fn auto_review_consults_the_guardian_and_runs_an_allowed_call_with_a_receipt() {
         let (_server, client) = guardian_mock(
@@ -21004,7 +21017,7 @@ mod child_permission_gate {
             .execute(
                 "agent_gate",
                 "bash",
-                json!({"command": "echo guardian-missing-usage | cat"}),
+                json!({"command": guardian_marker_pipeline("guardian-missing-usage")}),
             )
             .await
             .expect("semantic guardian success remains usable");
@@ -21044,7 +21057,7 @@ mod child_permission_gate {
         .await;
         let (registry, mut rx, manager) =
             worker_registry(ApprovalMode::Auto, false, true, Some(client));
-        let input = json!({"command": "echo guardian-cache-regression | cat"});
+        let input = json!({"command": guardian_marker_pipeline("guardian-cache-regression")});
 
         for _ in 0..2 {
             let output = registry

crates/tui/src/tui/subagent_routing.rs

@@ -1331,7 +1331,7 @@ mod tests {
             &MailboxMessage::TokenUsage {
                 agent_id: "agent_route".to_string(),
                 source_id: "response-route".to_string(),
-                route: test_route(crate::config::ApiProvider::Openrouter, "vendor/model-real"),
+                route: Box::new(test_route(crate::config::ApiProvider::Openrouter, "vendor/model-real")),
                 usage: crate::models::Usage::default(),
             },
         );
@@ -1353,7 +1353,7 @@ mod tests {
             &MailboxMessage::TokenUsage {
                 agent_id: "agent_spend".to_string(),
                 source_id: "response-1".to_string(),
-                route: route.clone(),
+                route: Box::new(route.clone()),
                 usage: crate::models::Usage {
                     input_tokens: 1_000,
                     output_tokens: 40,
@@ -1367,7 +1367,7 @@ mod tests {
             &MailboxMessage::TokenUsage {
                 agent_id: "agent_spend".to_string(),
                 source_id: "response-2".to_string(),
-                route,
+                route: Box::new(route),
                 usage: crate::models::Usage {
                     input_tokens: 2_000,
                     output_tokens: 60,

crates/tui/src/tui/translation.rs

@@ -10,10 +10,12 @@
 //!
 //! - `needs_translation()` — heuristic to detect if text is predominantly
 //!   English and should be translated.
+//!
 //! The event loop dispatches focused translation requests through the exact
 //! provider/model client frozen for the originating turn. The dedicated agent
 //! receives only the source text and returns only the translation — no tool
 //! calls or conversation history.
+//!
 //! - `TranslationStatus` — tracks per-message translation status in the UI.
 
 /// Heuristic threshold: if more than this fraction of alphabetic characters