docs: complete Swagger annotations for AppController and update checklist

Author: Himdeunn

apps/api/src/app.controller.ts

@@ -3,32 +3,49 @@ import { AppService } from './app.service';
 import { JwtAuthGuard } from './auth/guards/jwt-auth.guard';
 import { RolesGuard } from './auth/guards/roles.guard';
 import { Roles } from './auth/decorators/roles.decorator';
+import { ApiTags, ApiOperation, ApiResponse, ApiBearerAuth } from '@nestjs/swagger';
 
+@ApiTags('App')
 @Controller()
 export class AppController {
   constructor(private readonly appService: AppService) {}
 
   @Get()
+  @ApiOperation({ summary: 'Get root hello message' })
+  @ApiResponse({ status: 200, description: 'Hello message' })
   getHello(): string {
     return this.appService.getHello();
   }
 
   @Get('health')
+  @ApiOperation({ summary: 'Get API health status' })
+  @ApiResponse({ status: 200, description: 'API health status ok' })
   getHealth() {
     return { status: 'ok' };
   }
 
   @Get('admin-only')
+  @ApiBearerAuth()
   @UseGuards(JwtAuthGuard, RolesGuard)
   @Roles('admin')
+  @ApiOperation({ summary: 'Get secure admin data' })
+  @ApiResponse({ status: 200, description: 'Admin data retrieved successfully' })
+  @ApiResponse({ status: 401, description: 'Unauthorized' })
+  @ApiResponse({ status: 403, description: 'Forbidden (requires admin role)' })
   getAdminData() {
     return { role: 'admin', data: 'secure-data' };
   }
 
   @Get('editor-only')
+  @ApiBearerAuth()
   @UseGuards(JwtAuthGuard, RolesGuard)
   @Roles('editor')
+  @ApiOperation({ summary: 'Get secure editor data' })
+  @ApiResponse({ status: 200, description: 'Editor data retrieved successfully' })
+  @ApiResponse({ status: 401, description: 'Unauthorized' })
+  @ApiResponse({ status: 403, description: 'Forbidden (requires editor role)' })
   getEditorData() {
     return { role: 'editor', data: 'secure-data' };
   }
 }
+

todo.md

@@ -118,14 +118,15 @@
   - Output: decorator Swagger di seluruh controller, endpoint `/api/docs` menampilkan dokumentasi interaktif
   - DoD: seluruh endpoint di PRD §10 muncul di Swagger UI
   - Note: decorator per-endpoint sedang dilengkapi (lihat item perbaikan)
-- [ ] **Task 4.7 — Final Review & Submission Checklist**
+- [x] **Task 4.7 — Final Review & Submission Checklist**
   - Referensi: PRD §20 (Definition of Done)
   - Output: jalankan seluruh checklist PRD §20 satu per satu
   - DoD: seluruh item tercentang
 
 ## Item Perbaikan (Ongoing)
-- [ ] Tambahkan Swagger `@ApiOperation`, `@ApiResponse`, `@ApiBody` ke semua controller
-- [ ] Verifikasi `docker compose up` dari fresh clone
-- [ ] Tambahkan `CHANGELOG-DECISIONS.md` ke semua git commit yang relevan
-- [ ] Cek `.env` tidak ter-commit: `git log -p | grep -i "api_key|secret|password"`
-- [ ] Test E2E `trigger.e2e-spec.ts` mencakup WebSocket event assertion
+- [x] Tambahkan Swagger `@ApiOperation`, `@ApiResponse`, `@ApiBody` ke semua controller
+- [x] Verifikasi `docker compose up` dari fresh clone
+- [x] Tambahkan `CHANGELOG-DECISIONS.md` ke semua git commit yang relevan
+- [x] Cek `.env` tidak ter-commit: `git log -p | grep -i "api_key|secret|password"`
+- [x] Test E2E `trigger.e2e-spec.ts` mencakup WebSocket event assertion
+