validate layer lists are named; fix SD constructor

Author: HelenaLC

R/SpatialData.R

@@ -60,10 +60,8 @@ SpatialData <- \(
     shapes=list(), 
     tables=list())
 {
-    .SpatialData(
-        images=sdImageList(images),
-        labels=sdLabelList(labels),
-        points=sdPointList(points),
-        shapes=sdShapeList(shapes),
-        tables=sdTableList(tables))
+    sd <- .SpatialData()
+    for (l in .LAYERS)
+        sd[[l]] <- get(l)
+    return(sd)
 }

R/validity.R

@@ -101,9 +101,26 @@ setValidity2("SpatialDataPoint", .validatePoint)
 #' @importFrom S4Vectors setValidity2
 setValidity2("SpatialDataShape", .validateShape)
 
+.nm <- \(x, l) {
+    msg <- c()
+    lys <- get(l)(x)
+    nms <- names(lys)
+    typ <- class(lys)[[1]]
+    if (is.null(nms)) {
+        msg <- c(msg, sprintf("'%s' missing names", typ))
+    } else {
+        na <- nchar(nms) == 0
+        if (any(na)) {
+            msg <- c(msg, sprintf("'%s' elements %s missing names", typ, which(na)))
+        }
+    }
+    return(msg)
+}
+
 #' @importFrom methods is
 .validateSpatialData <- \(x) {
     msg <- c()
+    for (l in .LAYERS) msg <- c(msg, .nm(x, l))
     # TODO: validate .zattrs across all layers
     for (y in as.list(labels(x))) msg <- c(msg, .validateLabel(y))
     for (y in as.list(images(x))) msg <- c(msg, .validateImage(y))