[display] display/typeDefinition doesn't work in object literal

[Gama11]

class Main {
	static function main() {
		var foo:Foo = { | bar: 0};
	}
}

typedef Foo = {bar:Int};

Invoking "go to type definition" at the | doesn't take you to Foo.

This may look a bit silly in the above example, but this can be especially useful in cases where there isn't a type hint nearby to use the regular "go to definition" on:

class Main {
	static function main() {
		var e:haxe.macro.Expr.ExprDef = null;
		switch (e) {
			case EObjectDecl(fields):
				fields.push({ |
					field: "foo",
					expr: macro "bar"
				})
			case _:
		}
	}
}

[Simn]

This seems a bit dodgy. It's true that the expected type at the position can be inferred as Foo, but it's not exactly correct to say that you're hovering on an instance of Foo. If we changed this, it would also show Foo if you're hovering on something that's structurally not Foo, e.g. { }.

[Gama11]

Hm.. it can't be done in a way that doesn't affect anything else? Checking for inference only on display/typeDefinition, or something..

[Simn]

I think it should show the same results for hover and type definition.

[Simn]

To clarify my stance on this: If you had something like var a:Float = 123 and hovered over the 123, you'd obviously expect Int for both hover and type definition even though the expected type is Float.

Technically, anonymous structures are no different: You hover over an instance of the anonymous structure type and even though that might be assignable to some named type, it's incorrect to say that it is of that type.

However, I now wonder if this is really pragmatic even if it's technically correct. The user's intent here is clearly to go to the definition of the expected type, so maybe it's indeed acceptable to treat hover and type definition differently in such cases.