v.9.1.0 webpack warning (p2)

[RARgames]

Describe the bug
When there is no date-fns-tz webpack shows a warning, but date-fns-tz is optional.
A followup on #6154 warning. The previous warning is gone, but different warning appeared:

To Reproduce
Install react-datepicker in a project with webpack, but without date-fns-tz

[client] Compiled with warnings.
[client]
[client] Critical dependency: the request of a dependency is an expression
[client]
[client] Search for the keywords to learn more about each warning.
[client] To ignore, add // eslint-disable-next-line to the line before.
[client]
[client] WARNING in ./node_modules/react-datepicker/dist/index.es.js 150:16-44
[client] Critical dependency: the request of a dependency is an expression
[client]
[client] webpack compiled with 1 warning

Expected behavior
There should be no warning message

[martijnrusschen]

Can you review #6182

[RARgames]

I saw it, no idea how to fix it yet.

[RARgames]

Probably related: https://github.com/orgs/webpack/discussions/18027

[semtselishev]

   // Dynamic require for date-fns-tz
        // Use a variable to prevent webpack from statically analyzing the require
        // and showing warnings when the optional dependency is not installed
        // See: https://github.com/Hacker0x01/react-datepicker/issues/6154
        var dateFnsTzModuleName = "date-fns-tz";
        // eslint-disable-next-line @typescript-eslint/no-require-imports
        dateFnsTz = require(dateFnsTzModuleName);

causes a warning in a webpack build

WARNING in ./node_modules/react-datepicker/dist/index.es.js 138:20-48
Critical dependency: the request of a dependency is an expression
    at CommonJsRequireContextDependency.getWarnings (<PROJECT_ROOT>/node_modules/webpack/lib/dependencies/ContextDependency.js:114:18)
    at Compilation.reportDependencyErrorsAndWarnings (<PROJECT_ROOT>/node_modules/webpack/lib/Compilation.js:3291:24)
    at <PROJECT_ROOT>/node_modules/webpack/lib/Compilation.js:2876:28
    at eval (eval at create (<PROJECT_ROOT>/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:29:1)
    at <PROJECT_ROOT>/node_modules/webpack/lib/FlagDependencyExportsPlugin.js:395:10
    at <PROJECT_ROOT>/node_modules/neo-async/async.js:2830:7
    at Object.each (<PROJECT_ROOT>/node_modules/neo-async/async.js:2850:39)
    at <PROJECT_ROOT>/node_modules/webpack/lib/FlagDependencyExportsPlugin.js:366:17
    at <PROJECT_ROOT>/node_modules/neo-async/async.js:2830:7
    at Object.each (<PROJECT_ROOT>/node_modules/neo-async/async.js:2850:39)
    at <PROJECT_ROOT>/node_modules/webpack/lib/FlagDependencyExportsPlugin.js:51:15
    at Hook.eval [as callAsync] (eval at create (<PROJECT_ROOT>/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:25:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (<PROJECT_ROOT>/node_modules/tapable/lib/Hook.js:18:14)
    at Compilation.finish (<PROJECT_ROOT>/node_modules/webpack/lib/Compilation.js:2861:28)
    at <PROJECT_ROOT>/node_modules/webpack/lib/Compiler.js:1336:19
    at process.processTicksAndRejections (node:internal/process/task_queues:85:11)

when I simply import import DatePicker from "react-datepicker";
I tried to install date-fns and date-fns-tz but the problem persists

[chenbolan]

I encountered the same error. Is there still no solution to this problem?

WARNING in ./node_modules/react-datepicker/dist/index.es.js 138:20-48
  Critical dependency: the request of a dependency is an expression

[kunjanoscd]

Same here, encountering the warning.
At this point, avoiding to update to v9, even through on v8 there is a bug where we can't choose a date prior to year 1800.

[semtselishev]

the best fix I found is to disable this warning in the config

  ignoreWarnings: [
    w =>
      w.message?.includes('Critical dependency: the request of a dependency is an expression') &&
      /react-datepicker[\/\\]dist[\/\\]index\.es\.js/.test(w.module?.resource || ''),
  ],

[acha5066]

I don't think this has anything to do with date-fns-tz as I have that installed but still get the warning. For what it's worth this doesn't appear to affect the functionality at all, at least in my case the datepicker is working as expected.