feat(TDA): add TypeDeductionAnalysis library and bump to c++20

Author: EmilioCorigliano

.github/workflows/main.yml

@@ -16,8 +16,14 @@ jobs:
       - name: Checking out ASPIS
         uses: actions/checkout@v4
         with:
-          path: ASPIS
+          submodules: recursive
+          fetch-depth: 0
 
+      - name: Init submodules
+        run: |
+          git submodule sync --recursive
+          git submodule update --init --recursive
+
       - name: Install system dependencies
         run: |
           sudo apt update
@@ -40,7 +46,7 @@ jobs:
 
       - name: Compiling ASPIS
         shell: bash
-        working-directory: ${{ github.workspace }}/ASPIS
+        working-directory: ${{ github.workspace }}
         run: |
           ccache --set-config=max_size=${CCACHE_MAXSIZE}
           ccache --zero-stats
@@ -63,18 +69,18 @@ jobs:
         id: pip-cache
         with:
           path: ~/.cache/pip
-          key: pip-${{ hashFiles('${{ github.workspace }}/ASPIS/testing/requirements.txt') }}
+          key: pip-${{ hashFiles('${{ github.workspace }}/testing/requirements.txt') }}
           restore-keys: |
             pip-
       - name: Install Python requirements
         shell: bash        
         if: steps.restore-ccache.outputs.cache-hit != 'true'
-        working-directory: ${{ github.workspace }}/ASPIS/testing
+        working-directory: ${{ github.workspace }}/testing
         run: |
            pip install -r requirements.txt
       - name: Testing ASPIS
         shell: bash
-        working-directory: ${{ github.workspace }}/ASPIS/testing
+        working-directory: ${{ github.workspace }}/testing
         run: |
            pytest test.py --no-header -v
 

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "libs/TypeDeductionAnalysis"]
+	path = libs/TypeDeductionAnalysis
+	url = https://github.com/NiccoloN/TypeDeductionAnalysis.git

CMakeLists.txt

@@ -21,10 +21,11 @@ include_directories(SYSTEM ${LLVM_INCLUDE_DIRS})
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-rtti")
 #endif()
 
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++17")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++20")
 
 message(STATUS "Found LLVM definitions ${LLVM_DEFINITIONS_LIST}")
 message(STATUS "Found LLVM include dirs ${LLVM_INCLUDE_DIRS}")
 message(STATUS "RTTI: ${LLVM_ENABLE_RTTI}")
 
+add_subdirectory(libs/TypeDeductionAnalysis)
 add_subdirectory(passes)

passes/ASPIS.h

@@ -6,6 +6,7 @@
 #include "llvm/Pass.h"
 #include <llvm/IR/Instructions.h>
 #include "Utils/Utils.h"
+#include "TypeDeductionAnalysis.hpp"
 #include <map>
 #include <set>
 
@@ -40,7 +41,8 @@ class EDDI : public PassInfoMixin<EDDI> {
         std::set<Function*> toHardenFunctions;
         std::set<Value*> toHardenVariables;
         std::set<Value*> DuplicatedCalls;
-
+        tda::TypeDeductionAnalysis tda;
+        tda::TypeDeductionAnalysis::Result deducedTypes;
         std::string entryPoint;
 
         LinkageMap linkageMap;

passes/CMakeLists.txt

@@ -7,6 +7,7 @@ add_library(EDDI SHARED
 				FuncRetToRef.cpp
 				Utils/Utils.cpp
 )
+target_link_libraries(EDDI PUBLIC TypeDeductionAnalysis)
 target_compile_definitions(EDDI PRIVATE DUPLICATE_ALL SELECTIVE_CHECKING=0 CHECK_AT_STORES CHECK_AT_CALLS CHECK_AT_BRANCH)
 
 # REDDI 
@@ -16,6 +17,7 @@ add_library(REDDI SHARED
     FuncRetToRef.cpp
     Utils/Utils.cpp
 )
+target_link_libraries(REDDI PUBLIC TypeDeductionAnalysis)
 target_compile_definitions(REDDI PRIVATE SELECTIVE_CHECKING=0 CHECK_AT_STORES CHECK_AT_CALLS CHECK_AT_BRANCH)
 
 
@@ -26,6 +28,7 @@ add_library(FDSC SHARED
 				FuncRetToRef.cpp
 				Utils/Utils.cpp
 )
+target_link_libraries(FDSC PUBLIC TypeDeductionAnalysis)
 target_compile_definitions(FDSC PRIVATE DUPLICATE_ALL SELECTIVE_CHECKING=1 CHECK_AT_STORES CHECK_AT_CALLS CHECK_AT_BRANCH)
 
 # sEDDI
@@ -35,6 +38,7 @@ add_library(SEDDI SHARED
 				FuncRetToRef.cpp
 				Utils/Utils.cpp
 )
+target_link_libraries(SEDDI PUBLIC TypeDeductionAnalysis)
 target_compile_definitions(SEDDI PRIVATE DUPLICATE_ALL SELECTIVE_CHECKING=0 CHECK_AT_CALLS CHECK_AT_BRANCH)
 
 
@@ -43,12 +47,14 @@ add_library(CFCSS SHARED
 				CFCSS.cpp
 				Utils/Utils.cpp
 )
+target_link_libraries(CFCSS PUBLIC TypeDeductionAnalysis)
 
 # RASM
 add_library(RASM SHARED
 				RASM.cpp
 				Utils/Utils.cpp
 )
+target_link_libraries(RASM PUBLIC TypeDeductionAnalysis)
 target_compile_definitions(RASM PRIVATE INTER_FUNCTION_CFC=0)
 
 
@@ -57,15 +63,18 @@ add_library(INTER_RASM SHARED
 				RASM.cpp
 				Utils/Utils.cpp
 )
+target_link_libraries(INTER_RASM PUBLIC TypeDeductionAnalysis)
 target_compile_definitions(INTER_RASM PRIVATE INTER_FUNCTION_CFC=1)
 
 # RACFED
 add_library(RACFED SHARED
 								RACFED.cpp
 								Utils/Utils.cpp
 )
+target_link_libraries(RACFED PUBLIC TypeDeductionAnalysis)
 
 add_library(PROFILER SHARED
 				Profiling/ASPISCheckProfiler.cpp
 				Utils/Utils.cpp
 )
+target_link_libraries(PROFILER PUBLIC TypeDeductionAnalysis)

passes/EDDI.cpp

@@ -37,11 +37,11 @@
 #include <map>
 #include <queue>
 #include <unordered_set>
-// #include "../TypeDeductionAnalysis/TypeDeductionAnalysis.hpp"
 
 #include "Utils/Utils.h"
 
 using namespace llvm;
+using namespace tda;
 
 #define DEBUG_TYPE "eddi_verification"
 
@@ -1565,6 +1565,15 @@ PreservedAnalyses EDDI::run(Module &Md, ModuleAnalysisManager &AM) {
   // Fixing the duplicated constructors
   fixDuplicatedConstructors(Md);
 
+  deducedTypes = tda.run(Md, AM);
+
+  // Save deduced transparent types
+  for (auto& [value, deducedTypes] : deducedTypes.transparentTypes) {
+    if (!deducedTypes.empty()) {
+      errs() << "Deduced transparent type for " << *value << ": " << (*deducedTypes.begin()).get()->toString() << "\n";
+    }
+  }
+
   // list of duplicated instructions to remove since they are equal to the original
   std::set<CallBase *> GrayAreaCallsToFix;
   int iFn = 1;