Commit be29ef4
committed
fix: unchain merge-tags:generate from docs:generate -- it broke the Pages deploy
docs:generate runs inside .github/workflows/deploy.yml, so appending a step that
hard-fails without MERGE_TAGS_TOKEN took the entire site build down with it: run
32555981823 failed on "no token" where the previous deploy had succeeded. My
change, my mistake.
The fetcher still fails loudly -- that is right for the artifact, because an
empty catalog renders as a product with no merge tags. It is not right for it to
decide whether every other page on the site ships.
It stays an explicit script. Once the secret exists, deploy.yml gets its own
step, which the fetcher's docblock now spells out.1 parent 5637c2f commit be29ef4
2 files changed
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
15 | 29 | | |
16 | 30 | | |
17 | 31 | | |
| |||
0 commit comments