From d3c2166d49bab387eecc6203b349897e255875ef Mon Sep 17 00:00:00 2001 From: Michael Giuffrida Date: Fri, 13 Jun 2014 14:31:13 -0700 Subject: [PATCH] Listen to input event instead of keypress. This way the last character typed is included in the saved state. --- lab6_lifecycle/angularjs/controller.js | 4 +--- lab6_lifecycle/javascript/controller.js | 5 +---- lab7_useridentification/angularjs/controller.js | 4 +--- lab7_useridentification/javascript/controller.js | 5 +---- lab8_webresources/angularjs/1_webview/controller.js | 4 +--- .../angularjs/2_loading_resources/controller.js | 4 +--- lab8_webresources/javascript/1_webview/controller.js | 6 +----- .../javascript/2_loading_resources/controller.js | 4 +--- lab9_multipleviews/angularjs/controller.js | 4 +--- lab9_multipleviews/javascript/controller.js | 5 +---- 10 files changed, 10 insertions(+), 35 deletions(-) diff --git a/lab6_lifecycle/angularjs/controller.js b/lab6_lifecycle/angularjs/controller.js index 361b51f..1d1ac1c 100644 --- a/lab6_lifecycle/angularjs/controller.js +++ b/lab6_lifecycle/angularjs/controller.js @@ -126,9 +126,7 @@ window.addEventListener('load', function() { chrome.storage.local.set({'newtodo': newTodoInput.value}); }; newTodoInput = document.querySelector('input[type="text"]'); - newTodoInput.addEventListener('keypress' , function() { - saveTransientState(); - }) + newTodoInput.addEventListener('input', saveTransientState); }); diff --git a/lab6_lifecycle/javascript/controller.js b/lab6_lifecycle/javascript/controller.js index b768f77..92b6447 100644 --- a/lab6_lifecycle/javascript/controller.js +++ b/lab6_lifecycle/javascript/controller.js @@ -278,9 +278,6 @@ window.addEventListener('DOMContentLoaded', function() { chrome.storage.local.set({'newtodo': newTodoInput.value}); }; - newTodoInput.addEventListener('keypress' , function() { - saveTransientState(); - }) - + newTodoInput.addEventListener('input', saveTransientState); }); diff --git a/lab7_useridentification/angularjs/controller.js b/lab7_useridentification/angularjs/controller.js index 102f08c..a08e037 100644 --- a/lab7_useridentification/angularjs/controller.js +++ b/lab7_useridentification/angularjs/controller.js @@ -148,9 +148,7 @@ window.addEventListener('load', function() { chrome.storage.local.set({'newtodo': newTodoInput.value}); }; newTodoInput = document.querySelector('input[type="text"]'); - newTodoInput.addEventListener('keypress' , function() { - saveTransientState(); - }) + newTodoInput.addEventListener('input', saveTransientState); }); diff --git a/lab7_useridentification/javascript/controller.js b/lab7_useridentification/javascript/controller.js index 7ae8db6..59ff220 100644 --- a/lab7_useridentification/javascript/controller.js +++ b/lab7_useridentification/javascript/controller.js @@ -286,10 +286,7 @@ window.addEventListener('DOMContentLoaded', function() { chrome.storage.local.set({'newtodo': newTodoInput.value}); }; - newTodoInput.addEventListener('keypress' , function() { - saveTransientState(); - }) - + newTodoInput.addEventListener('input', saveTransientState); /** diff --git a/lab8_webresources/angularjs/1_webview/controller.js b/lab8_webresources/angularjs/1_webview/controller.js index 8fa525a..74d2f72 100644 --- a/lab8_webresources/angularjs/1_webview/controller.js +++ b/lab8_webresources/angularjs/1_webview/controller.js @@ -135,9 +135,7 @@ window.addEventListener('load', function() { chrome.storage.local.set({'newtodo': newTodoInput.value}); }; newTodoInput = document.querySelector('input[type="text"]'); - newTodoInput.addEventListener('keypress' , function() { - saveTransientState(); - }) + newTodoInput.addEventListener('input', saveTransientState); }); diff --git a/lab8_webresources/angularjs/2_loading_resources/controller.js b/lab8_webresources/angularjs/2_loading_resources/controller.js index d4ab0a2..d6e44fd 100644 --- a/lab8_webresources/angularjs/2_loading_resources/controller.js +++ b/lab8_webresources/angularjs/2_loading_resources/controller.js @@ -162,8 +162,6 @@ window.addEventListener('load', function() { chrome.storage.local.set({'newtodo': newTodoInput.value}); }; newTodoInput = document.querySelector('input[type="text"]'); - newTodoInput.addEventListener('keypress' , function() { - saveTransientState(); - }) + newTodoInput.addEventListener('input', saveTransientState); }); diff --git a/lab8_webresources/javascript/1_webview/controller.js b/lab8_webresources/javascript/1_webview/controller.js index b546d05..3635719 100644 --- a/lab8_webresources/javascript/1_webview/controller.js +++ b/lab8_webresources/javascript/1_webview/controller.js @@ -295,10 +295,6 @@ window.addEventListener('DOMContentLoaded', function() { chrome.storage.local.set({'newtodo': newTodoInput.value}); }; - newTodoInput.addEventListener('keypress' , function() { - saveTransientState(); - }) - - + newTodoInput.addEventListener('input', saveTransientState); }); diff --git a/lab8_webresources/javascript/2_loading_resources/controller.js b/lab8_webresources/javascript/2_loading_resources/controller.js index a62330c..fc2d580 100644 --- a/lab8_webresources/javascript/2_loading_resources/controller.js +++ b/lab8_webresources/javascript/2_loading_resources/controller.js @@ -315,9 +315,7 @@ window.addEventListener('DOMContentLoaded', function() { chrome.storage.local.set({'newtodo': newTodoInput.value}); }; - newTodoInput.addEventListener('keypress' , function() { - saveTransientState(); - }) + newTodoInput.addEventListener('input', saveTransientState); /** diff --git a/lab9_multipleviews/angularjs/controller.js b/lab9_multipleviews/angularjs/controller.js index bd8a1fa..2b873e9 100644 --- a/lab9_multipleviews/angularjs/controller.js +++ b/lab9_multipleviews/angularjs/controller.js @@ -81,9 +81,7 @@ window.addEventListener('load', function() { chrome.storage.local.set({'newtodo': newTodoInput.value}); }; newTodoInput = document.querySelector('input[type="text"]'); - newTodoInput.addEventListener('keypress' , function() { - saveTransientState(); - }) + newTodoInput.addEventListener('input', saveTransientState); }); diff --git a/lab9_multipleviews/javascript/controller.js b/lab9_multipleviews/javascript/controller.js index 743b1c6..8666023 100644 --- a/lab9_multipleviews/javascript/controller.js +++ b/lab9_multipleviews/javascript/controller.js @@ -242,10 +242,7 @@ window.addEventListener('DOMContentLoaded', function() { chrome.storage.local.set({'newtodo': newTodoInput.value}); }; - newTodoInput.addEventListener('keypress' , function() { - saveTransientState(); - }) - + newTodoInput.addEventListener('input', saveTransientState); /**