Go To Definition Support

[jcat4]

Hiya!

I don't know if this is something this plugin could handle, but I've noticed that any javascript within a liquid file doesn't support some of VS Code's fancy Rich Language features, especially the "Go to Definition" functionality.

Would be super awesome if something like this could be implemented. 😀

[jcat4]

Looked into this a little bit, and it does look like it needs to be implemented as a feature of the LSP.
https://code.visualstudio.com/docs/extensionAPI/language-support#_show-definitions-of-a-symbol

[jcat4]

I spent a little time trying to figure out how to get it working on my own, and the furthest I got was getting the right-click option to appear. I don't know how to implement the logic in the provideDefinition function.

I feel like one should be able to just extend the functionality in the same way the HTML LSP handles it. If Liquid files are essentially HTML/(S)CSS files with some templating syntax, and I want to see where a JS function was initialized within a script tag, it should be able to just work the same as a regular HTML file, right?

Maybe someone more experienced in VS Code extension development could chime in. :P